[webkit-changes] [WebKit/WebKit] 40fe7e: Rename RenderObjectBitfields and RenderObjectFlag ...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 40fe7e6e2826442f328c459bb322fcc5cf343cd8
      https://github.com/WebKit/WebKit/commit/40fe7e6e2826442f328c459bb322fcc5cf343cd8
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-12-20 (Wed, 20 Dec 2023)

  Changed paths:
    M Source/WebCore/rendering/RenderBox.cpp
    M Source/WebCore/rendering/RenderObject.cpp
    M Source/WebCore/rendering/RenderObject.h

  Log Message:
  -----------
  Rename RenderObjectBitfields and RenderObjectFlag to StateBitfields and StateFlag respectively
https://bugs.webkit.org/show_bug.cgi?id=266681

Reviewed by Antti Koivisto.

Renamed RenderObjectBitfields and RenderObjectFlag to StateBitfields and StateFlag respectively.

Also moved two bit flags for paint containment and SVG transforms from RenderObjectRareData to
StateFlag to make them more future proof.

In addition, simplified RenderObjectRareData by removing the use of bitfields.

Finally, use OptionSet for keeping track of trimmed margins instead of manually coercing to unsigned.

* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::markMarginAsTrimmed):
(WebCore::RenderBox::clearTrimmedMarginsMarkings):
(WebCore::RenderBox::hasTrimmedMargin const):
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::clearNeedsLayout):
(WebCore::RenderObject::setPreferredLogicalWidthsDirty):
(WebCore::RenderObject::invalidateContainerPreferredLogicalWidths):
(WebCore::RenderObject::destroy):
(WebCore::RenderObject::setSelectionState):
(WebCore::RenderObject::setHasReflection):
(WebCore::RenderObject::setHasOutlineAutoAncestor):
(WebCore::RenderObject::ensureRareData):
(WebCore::RenderObject::removeRareData):
(WebCore::RenderObject::setHasSVGTransform): Deleted.
(WebCore::RenderObject::setPaintContainmentApplies): Deleted.
(WebCore::RenderObject::RenderObjectRareData::RenderObjectRareData): Deleted.
* Source/WebCore/rendering/RenderObject.h:
(WebCore::RenderObject::beingDestroyed const):
(WebCore::RenderObject::everHadLayout const):
(WebCore::RenderObject::childrenInline const):
(WebCore::RenderObject::setChildrenInline):
(WebCore::RenderObject::fragmentedFlowState const):
(WebCore::RenderObject::setFragmentedFlowState):
(WebCore::RenderObject::isFloating const):
(WebCore::RenderObject::isPositioned const):
(WebCore::RenderObject::isInFlowPositioned const):
(WebCore::RenderObject::isOutOfFlowPositioned const):
(WebCore::RenderObject::isRelativelyPositioned const):
(WebCore::RenderObject::isStickilyPositioned const):
(WebCore::RenderObject::isInline const):
(WebCore::RenderObject::isReplacedOrInlineBlock const):
(WebCore::RenderObject::isHorizontalWritingMode const):
(WebCore::RenderObject::hasReflection const):
(WebCore::RenderObject::hasOutlineAutoAncestor const):
(WebCore::RenderObject::paintContainmentApplies const):
(WebCore::RenderObject::hasSVGTransform const):
(WebCore::RenderObject::isExcludedFromNormalLayout const):
(WebCore::RenderObject::setIsExcludedFromNormalLayout):
(WebCore::RenderObject::hasLayer const):
(WebCore::RenderObject::hasVisibleBoxDecorations const):
(WebCore::RenderObject::selfNeedsLayout const):
(WebCore::RenderObject::needsPositionedMovementLayout const):
(WebCore::RenderObject::posChildNeedsLayout const):
(WebCore::RenderObject::needsSimplifiedNormalFlowLayout const):
(WebCore::RenderObject::normalChildNeedsLayout const):
(WebCore::RenderObject::preferredLogicalWidthsDirty const):
(WebCore::RenderObject::hasNonVisibleOverflow const):
(WebCore::RenderObject::hasTransformRelatedProperty const):
(WebCore::RenderObject::clearPositionedState):
(WebCore::RenderObject::setFloating):
(WebCore::RenderObject::setInline):
(WebCore::RenderObject::setReplacedOrInlineBlock):
(WebCore::RenderObject::setHorizontalWritingMode):
(WebCore::RenderObject::setHasNonVisibleOverflow):
(WebCore::RenderObject::setHasLayer):
(WebCore::RenderObject::setHasTransformRelatedProperty):
(WebCore::RenderObject::setPaintContainmentApplies):
(WebCore::RenderObject::setHasSVGTransform):
(WebCore::RenderObject::selectionState const):
(WebCore::RenderObject::setNeedsPositionedMovementLayoutBit):
(WebCore::RenderObject::setNormalChildNeedsLayoutBit):
(WebCore::RenderObject::setPosChildNeedsLayoutBit):
(WebCore::RenderObject::setNeedsSimplifiedNormalFlowLayoutBit):
(WebCore::RenderObject::setEverHadLayout):
(WebCore::RenderObject::hasRareData const):
(WebCore::RenderObject::StateBitfields::flags const):
(WebCore::RenderObject::StateBitfields::hasFlag const):
(WebCore::RenderObject::StateBitfields::setFlag):
(WebCore::RenderObject::StateBitfields::clearFlag):
(WebCore::RenderObject::setNeedsLayout):
(WebCore::RenderObject::setHasVisibleBoxDecorations):
(WebCore::RenderObject::invalidateBackgroundObscurationStatus):
(WebCore::RenderObject::backgroundIsKnownToBeObscured):
(WebCore::RenderObject::setPositionState):
(WebCore::RenderObject::RenderObjectBitfields::flags const): Deleted.
(WebCore::RenderObject::RenderObjectBitfields::hasFlag const): Deleted.
(WebCore::RenderObject::RenderObjectBitfields::setFlag): Deleted.
(WebCore::RenderObject::RenderObjectBitfields::clearFlag): Deleted.
(WebCore::RenderObject::RenderObjectBitfields::isOutOfFlowPositioned const): Deleted.
(WebCore::RenderObject::RenderObjectBitfields::isRelativelyPositioned const): Deleted.
(WebCore::RenderObject::RenderObjectBitfields::isStickilyPositioned const): Deleted.
(WebCore::RenderObject::RenderObjectBitfields::isPositioned const): Deleted.
(WebCore::RenderObject::RenderObjectBitfields::setPositionedState): Deleted.
(WebCore::RenderObject::RenderObjectBitfields::clearPositionedState): Deleted.
(WebCore::RenderObject::RenderObjectBitfields::selectionState const): Deleted.
(WebCore::RenderObject::RenderObjectBitfields::setSelectionState): Deleted.
(WebCore::RenderObject::RenderObjectBitfields::fragmentedFlowState const): Deleted.
(WebCore::RenderObject::RenderObjectBitfields::setFragmentedFlowState): Deleted.
(WebCore::RenderObject::RenderObjectBitfields::boxDecorationState const): Deleted.
(WebCore::RenderObject::RenderObjectBitfields::setBoxDecorationState): Deleted.

Canonical link: https://commits.webkit.org/272329@main