[webkit-changes] [WebKit/WebKit] 58e0ef: Wait until the tab load has completed before testi...

kiaraarose noreply at github.com
Tue Dec 19 13:39:04 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 58e0ef1f7853c5fb889e2bc03304503548e0c171
      https://github.com/WebKit/WebKit/commit/58e0ef1f7853c5fb889e2bc03304503548e0c171
  Author: Kiara Rose <kiara_rose at apple.com>
  Date:   2023-12-19 (Tue, 19 Dec 2023)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm

  Log Message:
  -----------
  Wait until the tab load has completed before testing execute script for extension.
https://bugs.webkit.org/show_bug.cgi?id=266647
rdar://119398971

Reviewed by Timothy Hatcher.

Updated the check under `browser.tabs.onUpdated` event listener for the tab load being complete before
testing the executeScript API. If the load isn't complete, we will be injecting the script too early
for the test results to be accurate.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPITabs.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/272295@main




More information about the webkit-changes mailing list