[webkit-changes] [WebKit/WebKit] 767a3b: [TextureMapper] right side of for-loop condition m...
Fujii Hironori
noreply at github.com
Tue Dec 19 12:18:55 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 767a3b1ebacc83fda69adabd2cd05dcb44eaa087
https://github.com/WebKit/WebKit/commit/767a3b1ebacc83fda69adabd2cd05dcb44eaa087
Author: Fujii Hironori <Hironori.Fujii at sony.com>
Date: 2023-12-19 (Tue, 19 Dec 2023)
Changed paths:
M Source/WebCore/platform/graphics/texmap/TextureMapper.cpp
M Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp
Log Message:
-----------
[TextureMapper] right side of for-loop condition must be constant for ES SL 1.0
https://bugs.webkit.org/show_bug.cgi?id=261870
Reviewed by Miguel Gomez.
After 267646 at main improved gaussian blur filter, nothing drawn on
Raspberry Pi 3 which supports only GLES 2.0. The shader compiler
reports the following errors.
> Program log: ERROR:OPTIMIZER-3 (fragment shader, line 48) Support for for loops is restricted : right side of condition expression must be constant
> Program log: ERROR:OPTIMIZER-3 (fragment shader, line 49) Support for for loops is restricted : right side of condition expression must be constant
* Source/WebCore/platform/graphics/texmap/TextureMapper.cpp: Zero-fills the kernel.
* Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp:
Use a constant GAUSSIAN_KERNEL_MAX_HALF_SIZE for the for-loop of
applyBlurFilter and applyAlphaBlur for GLES<3.0 (ESSL 1.0)
Canonical link: https://commits.webkit.org/272287@main
More information about the webkit-changes
mailing list