[webkit-changes] [WebKit/WebKit] bcdeb1: [IFC][Ruby] Anonymous bases should have white-spac...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bcdeb1ae72eb306219987658997deb4159a9ccb9
      https://github.com/WebKit/WebKit/commit/bcdeb1ae72eb306219987658997deb4159a9ccb9
  Author: Antti Koivisto <antti at apple.com>
  Date:   2023-12-19 (Tue, 19 Dec 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/fast/ruby/floating-ruby-text-expected.txt
    M LayoutTests/fast/ruby/positioned-ruby-text-expected.txt
    M LayoutTests/platform/ios/TestExpectations
    M Source/WebCore/rendering/RenderElement.cpp
    M Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp
    M Source/WebCore/rendering/updating/RenderTreeBuilderRuby.h

  Log Message:
  -----------
  [IFC][Ruby] Anonymous bases should have white-space:nowrap
https://bugs.webkit.org/show_bug.cgi?id=266635
rdar://119864996

Reviewed by Alan Baradlay.

The UA stylesheet has 'white-space: nowrap' for bases https://www.w3.org/TR/css-ruby-1/#default-ua-ruby.
This should also be applied to anonymous bases. The behavior matches Firefox.

* LayoutTests/TestExpectations:
* LayoutTests/fast/ruby/floating-ruby-text-expected.txt:
* LayoutTests/fast/ruby/positioned-ruby-text-expected.txt:
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::propagateStyleToAnonymousChildren):

Don't reset ruby style when propagating style changes to anonymous children.

* Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp:
(WebCore::createAnonymousStyleForRuby):

Set 'white-space: nowrap' to anonymous base style.

(WebCore::createAnonymousRendererForRuby):

Factor into functions.

(WebCore::RenderTreeBuilder::Ruby::findOrCreateParentForStyleBasedRubyChild):
(WebCore::RenderTreeBuilder::Ruby::attachForStyleBasedRuby):
* Source/WebCore/rendering/updating/RenderTreeBuilderRuby.h:

Canonical link: https://commits.webkit.org/272285@main