[webkit-changes] [WebKit/WebKit] 07319b: [scroll-anchoring] findAnchorElementRecursive shou...

Nikos Mouchtaris noreply at github.com
Tue Dec 19 10:12:15 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 07319b820ce70ac6e01093ed0c356c2e1b0eb25d
      https://github.com/WebKit/WebKit/commit/07319b820ce70ac6e01093ed0c356c2e1b0eb25d
  Author: Nikolaos Mouchtaris <nmouchtaris at apple.com>
  Date:   2023-12-19 (Tue, 19 Dec 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/position-change-heuristic-in-nested-scroll-box-expected.txt
    M Source/WebCore/page/scrolling/ScrollAnchoringController.cpp
    M Source/WebCore/rendering/RenderObject.cpp

  Log Message:
  -----------
  [scroll-anchoring] findAnchorElementRecursive should descend into subscrollers if its not maintaining a scroll anchor
https://bugs.webkit.org/show_bug.cgi?id=262557
rdar://116411088

Reviewed by Simon Fraser.

We should only disallow descending into subscrollers if the subscroller is currently
maintaining a scroll anchor.

* LayoutTests/imported/w3c/web-platform-tests/css/css-scroll-anchoring/position-change-heuristic-in-nested-scroll-box-expected.txt:
* Source/WebCore/page/scrolling/ScrollAnchoringController.cpp:
(WebCore::elementForScrollableArea):
(WebCore::ScrollAnchoringController::invalidateAnchorElement):
(WebCore::canDescendIntoElement):
(WebCore::ScrollAnchoringController::examineCandidate):
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::findScrollAnchoringControllerForRenderer):

Canonical link: https://commits.webkit.org/272277@main




More information about the webkit-changes mailing list