[webkit-changes] [WebKit/WebKit] 09171c: REGRESSION (271643 at main): [ Monterey+ wk2 Release ...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 09171c10409c98d03cdb052de006780c66ce4ba0
      https://github.com/WebKit/WebKit/commit/09171c10409c98d03cdb052de006780c66ce4ba0
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2023-12-19 (Tue, 19 Dec 2023)

  Changed paths:
    M LayoutTests/fast/selectors/selection-window-inactive-stroke-color.html
    M LayoutTests/platform/mac-wk2/TestExpectations
    M Source/WebCore/rendering/RenderElement.cpp
    M Source/WebCore/rendering/RenderElement.h
    M Source/WebCore/rendering/RenderText.h
    M Source/WebCore/rendering/TextPaintStyle.cpp

  Log Message:
  -----------
  REGRESSION (271643 at main): [ Monterey+ wk2 Release x86_64 ] fast/selectors/selection-window-inactive-stroke-color.html is a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=266508
rdar://119737142

Reviewed by Antti Koivisto.

271643 at main modified `::selection` pseudo-style logic to use `getCachedPseudoStyle`
rather than `getUncachedPseudoStyle`, as `::grammar-error` and `::spelling-error`
were introduced.

However, in WebKit, `::selection` supports the non-standard `:window-inactive`.
Since it has the concept of changing state, it must use `getUncachedPseudoStyle`.
Fix by reverting the parts of 271643 at main which affected `::selection`.

This was not caught by EWS, since `selection-window-inactive-stroke-color.html`
has already been marked as a flaky failure. Fuzzy data has been added to
maintain test coverage. The reason for fuzziness should be investigated separately
in https://bugs.webkit.org/show_bug.cgi?id=216394.

* LayoutTests/fast/selectors/selection-window-inactive-stroke-color.html:
* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::rendererForPseudoStyleAcrossShadowBoundary const):
(WebCore::RenderElement::textSegmentPseudoStyle const):
(WebCore::RenderElement::selectionColor const):
(WebCore::RenderElement::selectionPseudoStyle const):
(WebCore::RenderElement::selectionBackgroundColor const):
* Source/WebCore/rendering/RenderElement.h:
* Source/WebCore/rendering/RenderText.h:
(WebCore::RenderText::selectionPseudoStyle const):
* Source/WebCore/rendering/TextPaintStyle.cpp:
(WebCore::computeTextSelectionPaintStyle):

Canonical link: https://commits.webkit.org/272275@main