[webkit-changes] [WebKit/WebKit] 9d0537: [Deprecated flexbox] Do not try to float position ...

Alan Baradlay noreply at github.com
Tue Dec 19 08:35:57 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9d05374a137f8700373f1f22c0707b152dfe6cd6
      https://github.com/WebKit/WebKit/commit/9d05374a137f8700373f1f22c0707b152dfe6cd6
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-12-19 (Tue, 19 Dec 2023)

  Changed paths:
    A LayoutTests/fast/flexbox/deprecated-flex-box-with-float-flex-item-expected.html
    A LayoutTests/fast/flexbox/deprecated-flex-box-with-float-flex-item.html
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/rendering/style/RenderStyleInlines.h
    M Source/WebCore/style/StyleAdjuster.cpp

  Log Message:
  -----------
  [Deprecated flexbox] Do not try to float position direct inflow children
https://bugs.webkit.org/show_bug.cgi?id=266599

Reviewed by Antti Koivisto.

Direct children with "float: left/right" are (correctly) laid out as if they were not float positioned. However at paint time, we treat them as floats
but don't find them in RenderBlockFlow::m_floatingObjects (since we don't populate this list in flex layout).

* LayoutTests/TestExpectations:
* LayoutTests/fast/flexbox/deprecated-flex-box-with-float-flex-item-expected.html: Added.
* LayoutTests/fast/flexbox/deprecated-flex-box-with-float-flex-item.html: Added.
* Source/WebCore/style/StyleAdjuster.cpp:
(WebCore::Style::Adjuster::adjust const):

Canonical link: https://commits.webkit.org/272271@main




More information about the webkit-changes mailing list