[webkit-changes] [WebKit/WebKit] 4be388: Ruby style cleanups

Antti Koivisto noreply at github.com
Tue Dec 19 07:00:10 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4be388cadb468d7b951a79e5ea6940a3aec607e6
      https://github.com/WebKit/WebKit/commit/4be388cadb468d7b951a79e5ea6940a3aec607e6
  Author: Antti Koivisto <antti at apple.com>
  Date:   2023-12-19 (Tue, 19 Dec 2023)

  Changed paths:
    M LayoutTests/fast/ruby/ruby-block-style-not-updated-expected.txt
    M Source/WebCore/html/RubyElement.cpp
    M Source/WebCore/html/RubyTextElement.cpp
    M Source/WebCore/style/StyleAdjuster.cpp

  Log Message:
  -----------
  Ruby style cleanups
https://bugs.webkit.org/show_bug.cgi?id=266623
rdar://119856171

Reviewed by Tim Nguyen and Alan Baradlay.

* LayoutTests/fast/ruby/ruby-block-style-not-updated-expected.txt:
* Source/WebCore/html/RubyElement.cpp:
(WebCore::RubyElement::createElementRenderer):
* Source/WebCore/html/RubyTextElement.cpp:
(WebCore::RubyTextElement::createElementRenderer):

Ensure we can't create legacy ruby renderers with css ruby enabled.

* Source/WebCore/style/StyleAdjuster.cpp:
(WebCore::Style::forceBidiIsolationForRuby):

Rename and include all cases to switch.

(WebCore::Style::Adjuster::adjust const):

Remove some no-op code.

(WebCore::Style::adjustUnicodeBidiForRuby): Deleted.

Canonical link: https://commits.webkit.org/272267@main




More information about the webkit-changes mailing list