[webkit-changes] [WebKit/WebKit] ceaf6d: Simplify 'targetNode' function from HitTestResult

Ahmad Saleem noreply at github.com
Tue Dec 19 06:31:11 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ceaf6d34ab11f187137f68e9127c99cd2678a752
      https://github.com/WebKit/WebKit/commit/ceaf6d34ab11f187137f68e9127c99cd2678a752
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-12-19 (Tue, 19 Dec 2023)

  Changed paths:
    M Source/WebCore/rendering/HitTestResult.cpp
    M Source/WebCore/rendering/HitTestResult.h

  Log Message:
  -----------
  Simplify 'targetNode' function from HitTestResult

https://bugs.webkit.org/show_bug.cgi?id=265891
rdar://problem/119566622

Reviewed by Tim Nguyen.

Merge: https://chromium.googlesource.com/chromium/blink/+/ceea705be631379fd0d012d4f20128ad3e7296ea

This patch is to simplify 'targetNode' function to return 'innerNode' rather than
old code introduced in 18736 at main, which didn't make sense: if a node is
disconnected, its parent element also has to be disconnected, which means
most of the logic in HitTestResult::targetNode was just dead code.

* Source/WebCore/rendering/HitTestResult.cpp:
(HitTestResult::targetNode): Deleted
* Source/WebCore/rendering/HitTestResult.h: Inlined 'targetNode' to return 'innerNode'

Canonical link: https://commits.webkit.org/272265@main




More information about the webkit-changes mailing list