[webkit-changes] [WebKit/WebKit] 9b9eb5: Replace 1-bit bitfields in RenderObjectBitfields w...

Ryosuke Niwa noreply at github.com
Tue Dec 19 00:05:28 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9b9eb59716b8ed70b8ada714e1c03ee7cb0c7b23
      https://github.com/WebKit/WebKit/commit/9b9eb59716b8ed70b8ada714e1c03ee7cb0c7b23
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-12-19 (Tue, 19 Dec 2023)

  Changed paths:
    M Source/WebCore/rendering/RenderBlockFlow.cpp
    M Source/WebCore/rendering/RenderObject.cpp
    M Source/WebCore/rendering/RenderObject.h

  Log Message:
  -----------
  Replace 1-bit bitfields in RenderObjectBitfields with RenderObjectFlag
https://bugs.webkit.org/show_bug.cgi?id=266609

Reviewed by Simon Fraser.

Replace macros to generate 1-bit bitfields in RenderObjectBitfields with newly introduced
RenderObjectFlag enum class for simplicity and clarity.

* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutBlock):
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::RenderObject):
(WebCore::RenderObject::clearNeedsLayout):
(WebCore::RenderObject::setPreferredLogicalWidthsDirty):
(WebCore::RenderObject::invalidateContainerPreferredLogicalWidths):
(WebCore::RenderObject::destroy):
(WebCore::RenderObject::ensureRareData):
(WebCore::RenderObject::removeRareData):
* Source/WebCore/rendering/RenderObject.h:
(WebCore::RenderObject::beingDestroyed const):
(WebCore::RenderObject::everHadLayout const):
(WebCore::RenderObject::childrenInline const):
(WebCore::RenderObject::setChildrenInline):
(WebCore::RenderObject::isAnonymous const):
(WebCore::RenderObject::isFloating const):
(WebCore::RenderObject::isRenderText const):
(WebCore::RenderObject::isRenderBox const):
(WebCore::RenderObject::isInline const):
(WebCore::RenderObject::isReplacedOrInlineBlock const):
(WebCore::RenderObject::isHorizontalWritingMode const):
(WebCore::RenderObject::hasReflection const):
(WebCore::RenderObject::isRenderFragmentedFlow const):
(WebCore::RenderObject::hasOutlineAutoAncestor const):
(WebCore::RenderObject::paintContainmentApplies const):
(WebCore::RenderObject::hasSVGTransform const):
(WebCore::RenderObject::isExcludedFromNormalLayout const):
(WebCore::RenderObject::setIsExcludedFromNormalLayout):
(WebCore::RenderObject::hasLayer const):
(WebCore::RenderObject::selfNeedsLayout const):
(WebCore::RenderObject::needsPositionedMovementLayout const):
(WebCore::RenderObject::posChildNeedsLayout const):
(WebCore::RenderObject::needsSimplifiedNormalFlowLayout const):
(WebCore::RenderObject::normalChildNeedsLayout const):
(WebCore::RenderObject::preferredLogicalWidthsDirty const):
(WebCore::RenderObject::hasNonVisibleOverflow const):
(WebCore::RenderObject::hasTransformRelatedProperty const):
(WebCore::RenderObject::setFloating):
(WebCore::RenderObject::setInline):
(WebCore::RenderObject::setIsRenderText):
(WebCore::RenderObject::setIsRenderBox):
(WebCore::RenderObject::setReplacedOrInlineBlock):
(WebCore::RenderObject::setHorizontalWritingMode):
(WebCore::RenderObject::setHasNonVisibleOverflow):
(WebCore::RenderObject::setHasLayer):
(WebCore::RenderObject::setHasTransformRelatedProperty):
(WebCore::RenderObject::setNeedsPositionedMovementLayoutBit):
(WebCore::RenderObject::setNormalChildNeedsLayoutBit):
(WebCore::RenderObject::setPosChildNeedsLayoutBit):
(WebCore::RenderObject::setNeedsSimplifiedNormalFlowLayoutBit):
(WebCore::RenderObject::setEverHadLayout):
(WebCore::RenderObject::hasRareData const):
(WebCore::RenderObject::RenderObjectBitfields::flags const):
(WebCore::RenderObject::RenderObjectBitfields::hasFlag const):
(WebCore::RenderObject::RenderObjectBitfields::setFlag):
(WebCore::RenderObject::RenderObjectBitfields::clearFlag):
(WebCore::RenderObject::setNeedsLayout):
(WebCore::RenderObject::needsSimplifiedNormalFlowLayoutOnly const):
(WebCore::RenderObject::needsLayout const):
(WebCore::RenderObject::needsPositionedMovementLayoutOnly const):
(WebCore::RenderObject::setHasRareData): Deleted.
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields): Deleted.

Canonical link: https://commits.webkit.org/272255@main




More information about the webkit-changes mailing list