[webkit-changes] [WebKit/WebKit] 57feb7: Devirtualize more RenderObject type checks

Ryosuke Niwa noreply at github.com
Mon Dec 18 18:21:43 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 57feb7424beb442bf5df7ca404f4439bbad72717
      https://github.com/WebKit/WebKit/commit/57feb7424beb442bf5df7ca404f4439bbad72717
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-12-18 (Mon, 18 Dec 2023)

  Changed paths:
    M Source/WebCore/rendering/RenderBlockFlow.h
    M Source/WebCore/rendering/RenderImage.cpp
    M Source/WebCore/rendering/RenderImage.h
    M Source/WebCore/rendering/RenderMedia.cpp
    M Source/WebCore/rendering/RenderMedia.h
    M Source/WebCore/rendering/RenderObject.h
    M Source/WebCore/rendering/RenderReplaced.cpp
    M Source/WebCore/rendering/RenderReplaced.h
    M Source/WebCore/rendering/RenderWidget.cpp
    M Source/WebCore/rendering/RenderWidget.h
    M Source/WebCore/rendering/svg/RenderSVGContainer.cpp
    M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGContainer.cpp

  Log Message:
  -----------
  Devirtualize more RenderObject type checks
https://bugs.webkit.org/show_bug.cgi?id=266592

Reviewed by Chris Dumez.

This PR adds more RenderElementType flags to devirtualize more type check functions.

Also add Flag suffix to LegacyRenderSVGContainer and RenderSVGContainer for consistency.

Also delete isMultiColumnBlockFlow(), which is never used.

* Source/WebCore/rendering/RenderBlockFlow.h:
* Source/WebCore/rendering/RenderImage.cpp:
(WebCore::RenderImage::RenderImage):
* Source/WebCore/rendering/RenderImage.h:
* Source/WebCore/rendering/RenderMedia.cpp:
(WebCore::RenderMedia::RenderMedia):
* Source/WebCore/rendering/RenderMedia.h:
* Source/WebCore/rendering/RenderObject.h:
(WebCore::RenderObject::isRenderMedia const):
(WebCore::RenderObject::isRenderImage const):
(WebCore::RenderObject::isRenderWidget const):
(WebCore::RenderObject::isRenderSVGContainer const):
(WebCore::RenderObject::isLegacyRenderSVGContainer const):
(WebCore::RenderObject::isMultiColumnBlockFlow const): Deleted.
* Source/WebCore/rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::RenderReplaced):
* Source/WebCore/rendering/RenderReplaced.h:
(WebCore::RenderReplaced::RenderReplaced):
* Source/WebCore/rendering/RenderWidget.cpp:
(WebCore::RenderWidget::RenderWidget):
* Source/WebCore/rendering/RenderWidget.h:
(WebCore::RenderWidget::isRenderWidget): Deleted.
* Source/WebCore/rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::RenderSVGContainer):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGContainer.cpp:
(WebCore::LegacyRenderSVGContainer::LegacyRenderSVGContainer):

Canonical link: https://commits.webkit.org/272248@main




More information about the webkit-changes mailing list