[webkit-changes] [WebKit/WebKit] 6f3389: Add test for Geolocation WatchID

Yusuke Suzuki noreply at github.com
Mon Dec 18 09:02:53 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6f33895ab672a2532b6f679301fb2c1d54aa635d
      https://github.com/WebKit/WebKit/commit/6f33895ab672a2532b6f679301fb2c1d54aa635d
  Author: Matthew Finkel <sysrqb at apple.com>
  Date:   2023-12-18 (Mon, 18 Dec 2023)

  Changed paths:
    A LayoutTests/http/tests/security/isolate-geolocation-watch-id-per-document-expected.txt
    A LayoutTests/http/tests/security/isolate-geolocation-watch-id-per-document.html
    A LayoutTests/http/tests/security/resources/popup-watchid.html

  Log Message:
  -----------
  Add test for Geolocation WatchID
https://bugs.webkit.org/show_bug.cgi?id=263277
rdar://8731258

Reviewed by David Kilzer.

Add a test that confirms the Geolocation WatchID is unique per document.

* LayoutTests/http/tests/security/isolate-geolocation-watch-id-per-document-expected.txt: Added.
* LayoutTests/http/tests/security/isolate-geolocation-watch-id-per-document.html: Added.
* LayoutTests/http/tests/security/resources/popup-watchid.html: Added.

Originally-landed-as: 267815.490 at safari-7617-branch (837e69390e41). rdar://119595145
Canonical link: https://commits.webkit.org/272220@main


  Commit: 9c58e7a622e8b97a50654fe6404562614e38dca8
      https://github.com/WebKit/WebKit/commit/9c58e7a622e8b97a50654fe6404562614e38dca8
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-12-18 (Mon, 18 Dec 2023)

  Changed paths:
    M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm

  Log Message:
  -----------
  -[WebAccessibilityObjectWrapperIOS _accessibilitySetFocus] needs to take the WebThreadLock
rdar://116882220

Reviewed by Ryosuke Niwa.

Use -[WebAccessibilityObjectWrapperIOS _prepareAccessibilityCall] to
ensure the WebThreadLock is taken before running this function.

* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper _accessibilitySetFocus:]):

Originally-landed-as: 267815.307 at safari-7617-branch (fdc510244825). rdar://119595084
Canonical link: https://commits.webkit.org/272221@main


  Commit: a0e24518e376536852236303ca67e26f706eb249
      https://github.com/WebKit/WebKit/commit/a0e24518e376536852236303ca67e26f706eb249
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-12-18 (Mon, 18 Dec 2023)

  Changed paths:
    M Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp

  Log Message:
  -----------
  Fix bad capture by reference in CDMInstanceSessionClearKey::loadSession()
https://bugs.webkit.org/show_bug.cgi?id=263254
rdar://117061886

Reviewed by Brent Fulgham.

Fix bad capture by reference in an asynchronous callback in CDMInstanceSessionClearKey::loadSession().

* Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp:
(WebCore::CDMInstanceSessionClearKey::loadSession):

Originally-landed-as: 267815.314 at safari-7617-branch (80d2fe008437). rdar://119595029
Canonical link: https://commits.webkit.org/272222@main


  Commit: 7736ce7fe69a564cac39dd0c2020a0a9d3416a3c
      https://github.com/WebKit/WebKit/commit/7736ce7fe69a564cac39dd0c2020a0a9d3416a3c
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2023-12-18 (Mon, 18 Dec 2023)

  Changed paths:
    M Source/JavaScriptCore/b3/B3ReduceStrength.cpp
    M Source/JavaScriptCore/b3/testb3.h
    M Source/JavaScriptCore/b3/testb3_1.cpp
    M Source/JavaScriptCore/b3/testb3_5.cpp

  Log Message:
  -----------
  [JSC] Wrong B3 range analysis on 64-bit values
https://bugs.webkit.org/show_bug.cgi?id=262224
rdar://115897433

Reviewed by Mark Lam.

This patch fixes B3's range analysis. When using 64bit value, we should use INT64_MIN / INT64_MAX instead of INT_MIN / INT_MAX.
We use std::numeric_limits to make it work. We also adjust `+ 1` check to avoid potential UB.

* Source/JavaScriptCore/b3/B3ReduceStrength.cpp:
* Source/JavaScriptCore/b3/testb3.h:
* Source/JavaScriptCore/b3/testb3_1.cpp:
(run):
* Source/JavaScriptCore/b3/testb3_5.cpp:
(testCheckAdd64Range):

Originally-landed-as: 267815.118 at safari-7617-branch (3e7f362d98b7). rdar://119594339
Canonical link: https://commits.webkit.org/272223@main


Compare: https://github.com/WebKit/WebKit/compare/629d6a1da6c4...7736ce7fe69a


More information about the webkit-changes mailing list