[webkit-changes] [WebKit/WebKit] dcd42a: Increase usage of dynamicDowncast in Accessibility...

Anne van Kesteren noreply at github.com
Mon Dec 18 00:44:05 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dcd42ae35333b577043cbe9e3eda1c4a5c66a471
      https://github.com/WebKit/WebKit/commit/dcd42ae35333b577043cbe9e3eda1c4a5c66a471
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-12-18 (Mon, 18 Dec 2023)

  Changed paths:
    M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
    M Source/WebCore/rendering/RenderThemeMac.h

  Log Message:
  -----------
  Increase usage of dynamicDowncast in AccessibilityRenderObject
https://bugs.webkit.org/show_bug.cgi?id=266553

Reviewed by Chris Dumez.

Also sprinkle some RefPtr around, but not too much as many methods in
this part of the code are not prepared to handle them.

* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::isInlineWithContinuation):
(WebCore::startOfContinuations):
(WebCore::firstChildIsInlineContinuation):
(WebCore::AccessibilityRenderObject::setValue):
(WebCore::AccessibilityRenderObject::widget const):
(WebCore::AccessibilityRenderObject::documentLinks):
(WebCore::AccessibilityRenderObject::accessibilityHitTest const):
(WebCore::AccessibilityRenderObject::renderObjectIsObservable const):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::inheritsPresentationalRole const):
(WebCore::AccessibilityRenderObject::addImageMapChildren):
(WebCore::AccessibilityRenderObject::addTextFieldChildren):
(WebCore::AccessibilityRenderObject::remoteSVGRootElement const):
(WebCore::AccessibilityRenderObject::addNodeOnlyChildren):
(WebCore::AccessibilityRenderObject::setAccessibleName):
(WebCore::AccessibilityRenderObject::getScrollableAreaIfScrollable const):
(WebCore::AccessibilityRenderObject::scrollTo const):
* Source/WebCore/rendering/RenderThemeMac.h:

Drive-by fix to remove some no longer used class members.

Canonical link: https://commits.webkit.org/272204@main




More information about the webkit-changes mailing list