[webkit-changes] [WebKit/WebKit] d8c955: Stop using CheckedPtr with ScriptExecutionContext

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d8c9557730575302c1dd4ddc51a04f2be4ee2ef4
      https://github.com/WebKit/WebKit/commit/d8c9557730575302c1dd4ddc51a04f2be4ee2ef4
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-12-16 (Sat, 16 Dec 2023)

  Changed paths:
    M Source/WebCore/Headers.cmake
    M Source/WebCore/Modules/encryptedmedia/CDM.cpp
    M Source/WebCore/Modules/encryptedmedia/MediaKeySession.h
    M Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeySession.h
    M Source/WebCore/Modules/indexeddb/IDBActiveDOMObject.h
    M Source/WebCore/Modules/notifications/Notification.h
    M Source/WebCore/Modules/webcodecs/WebCodecsAudioData.cpp
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/animation/WebAnimation.h
    M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
    M Source/WebCore/bindings/scripts/test/JS/JSTestCallbackFunction.cpp
    M Source/WebCore/bindings/scripts/test/JS/JSTestCallbackFunctionRethrow.cpp
    M Source/WebCore/bindings/scripts/test/JS/JSTestCallbackFunctionWithThisObject.cpp
    M Source/WebCore/bindings/scripts/test/JS/JSTestCallbackFunctionWithTypedefs.cpp
    M Source/WebCore/bindings/scripts/test/JS/JSTestCallbackInterface.cpp
    M Source/WebCore/bindings/scripts/test/JS/JSTestVoidCallbackFunction.cpp
    M Source/WebCore/crypto/SubtleCrypto.cpp
    M Source/WebCore/dom/AbortSignal.h
    M Source/WebCore/dom/ContextDestructionObserver.cpp
    M Source/WebCore/dom/ContextDestructionObserver.h
    A Source/WebCore/dom/ContextDestructionObserverInlines.h
    M Source/WebCore/dom/Document.h
    M Source/WebCore/dom/MessagePort.h
    M Source/WebCore/dom/RejectedPromiseTracker.h
    M Source/WebCore/dom/ScriptExecutionContext.h
    M Source/WebCore/html/track/TextTrack.h
    M Source/WebCore/page/LocalDOMWindow.h
    M Source/WebCore/page/ScreenOrientation.h
    M Source/WebCore/page/csp/ContentSecurityPolicy.h

  Log Message:
  -----------
  Stop using CheckedPtr with ScriptExecutionContext
https://bugs.webkit.org/show_bug.cgi?id=266525

Reviewed by Darin Adler.

Stop using CheckedPtr with ScriptExecutionContext. Use WeakPtr instead to
generate more actionable crashes.

This tested as performance neutral on Speedometer 2 & 3.

* Source/WebCore/Headers.cmake:
* Source/WebCore/Modules/encryptedmedia/CDM.cpp:
* Source/WebCore/Modules/encryptedmedia/MediaKeySession.h:
* Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeySession.h:
* Source/WebCore/Modules/indexeddb/IDBActiveDOMObject.h:
* Source/WebCore/Modules/notifications/Notification.h:
* Source/WebCore/Modules/webcodecs/WebCodecsAudioData.cpp:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/animation/WebAnimation.h:
* Source/WebCore/crypto/SubtleCrypto.cpp:
* Source/WebCore/dom/AbortSignal.h:
* Source/WebCore/dom/ContextDestructionObserver.h:
(WebCore::ContextDestructionObserver::scriptExecutionContext const): Deleted.
* Source/WebCore/dom/ContextDestructionObserverInlines.h: Added.
(WebCore::ContextDestructionObserver::scriptExecutionContext const):
* Source/WebCore/dom/Document.h:
* Source/WebCore/dom/MessagePort.h:
* Source/WebCore/dom/RejectedPromiseTracker.h:
* Source/WebCore/dom/ScriptExecutionContext.h:
* Source/WebCore/html/track/TextTrack.h:
* Source/WebCore/page/LocalDOMWindow.h:
* Source/WebCore/page/ScreenOrientation.h:
* Source/WebCore/page/csp/ContentSecurityPolicy.h:

Canonical link: https://commits.webkit.org/272186@main