[webkit-changes] [WebKit/WebKit] dd8019: Stop using CheckedPtr with Range

Chris Dumez noreply at github.com
Sat Dec 16 00:01:08 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dd8019d9d4f10eac0565f6d7eb5c64cc3c1ca58d
      https://github.com/WebKit/WebKit/commit/dd8019d9d4f10eac0565f6d7eb5c64cc3c1ca58d
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-12-15 (Fri, 15 Dec 2023)

  Changed paths:
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/Document.h
    M Source/WebCore/dom/Range.h
    M Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp

  Log Message:
  -----------
  Stop using CheckedPtr with Range
https://bugs.webkit.org/show_bug.cgi?id=266526

Reviewed by Ryosuke Niwa.

Stop using CheckedPtr with Range. Use WeakPtr instead to generate more
actionable crashes. This tested as performance neutral on Speedometer
2 & 3.

* Source/WebCore/dom/Document.cpp:
(WebCore::Document::parentlessNodeMovedToNewDocument):
* Source/WebCore/dom/Document.h:
* Source/WebCore/dom/Range.h:
* Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:
(WebKit::InjectedBundleRangeHandle::getOrCreate):
(WebKit::InjectedBundleRangeHandle::~InjectedBundleRangeHandle):

Canonical link: https://commits.webkit.org/272169@main




More information about the webkit-changes mailing list