[webkit-changes] [WebKit/WebKit] 6c744e: [macOS WK2] Some minor smart magnify cleanup

Simon Fraser noreply at github.com
Fri Dec 15 21:14:45 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6c744e1658390e109a97abd5cb4e339832b25a2f
      https://github.com/WebKit/WebKit/commit/6c744e1658390e109a97abd5cb4e339832b25a2f
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2023-12-15 (Fri, 15 Dec 2023)

  Changed paths:
    M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.mm
    M Source/WebKit/UIProcess/ViewGestureController.h
    M Source/WebKit/UIProcess/mac/ViewGestureControllerMac.mm
    M Source/WebKit/WebProcess/WebPage/ViewGestureGeometryCollector.cpp
    M Source/WebKit/WebProcess/WebPage/ViewGestureGeometryCollector.h
    M Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm

  Log Message:
  -----------
  [macOS WK2] Some minor smart magnify cleanup
https://bugs.webkit.org/show_bug.cgi?id=266527
rdar://119746523

Reviewed by Tim Horton, Chris Dumez and Wenson Hsieh.

Rename the 'origin' argument in various ViewGestureController smart magnification functions
to `gestureLocationInViewCoordinates`, since that's what it is.

Add some more `ViewGestures` logging, and convert some `Scrolling` logging to that channel.

Other minor code changes for cleanliness and readability. No behavior changes.

* Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxyMac::commitTransientZoom):
* Source/WebKit/UIProcess/ViewGestureController.h:
* Source/WebKit/UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::handleSmartMagnificationGesture):
(WebKit::ViewGestureController::didCollectGeometryForSmartMagnificationGesture):
* Source/WebKit/WebProcess/WebPage/ViewGestureGeometryCollector.cpp:
(WebKit::ViewGestureGeometryCollector::collectGeometryForSmartMagnificationGesture):
* Source/WebKit/WebProcess/WebPage/ViewGestureGeometryCollector.h:
* Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::commitTransientZoom):
(WebKit::TiledCoreAnimationDrawingArea::applyTransientZoomToPage):

Canonical link: https://commits.webkit.org/272164@main




More information about the webkit-changes mailing list