[webkit-changes] [WebKit/WebKit] 45c454: REGRESSION(254015 at main): ASSERTION FAILED: line <=...

[Vitaly Dyachkov]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 45c454419d247921b2a9ca4a2176f37645d6b3a6
      https://github.com/WebKit/WebKit/commit/45c454419d247921b2a9ca4a2176f37645d6b3a6
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2023-12-15 (Fri, 15 Dec 2023)

  Changed paths:
    M LayoutTests/platform/gtk/TestExpectations
    M Source/JavaScriptCore/debugger/DebuggerParseData.cpp

  Log Message:
  -----------
  REGRESSION(254015 at main): ASSERTION FAILED: line <= it->position.line
https://bugs.webkit.org/show_bug.cgi?id=266337

Reviewed by Nikolas Zimmermann.

As it might be seen from the code next to the assertion,
`DebuggerPausePositions::firstPositionAfter()` may return
`m_positions.end()`, for which line is undefined.

We should handle this case before verifying the assertion.

* LayoutTests/platform/gtk/TestExpectations:
* Source/JavaScriptCore/debugger/DebuggerParseData.cpp:
(JSC::DebuggerPausePositions::breakpointLocationForLineColumn):

Canonical link: https://commits.webkit.org/272122@main