[webkit-changes] [WebKit/WebKit] 12b180: [IFC][Ruby] text-emphasis is suppressed by annotation

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 12b180a5083b9235006b4c01bb02710c14cc4fc2
      https://github.com/WebKit/WebKit/commit/12b180a5083b9235006b4c01bb02710c14cc4fc2
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-12-15 (Fri, 15 Dec 2023)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.h
    M Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h
    M Source/WebCore/layout/formattingContexts/inline/InlineLevelBoxInlines.h
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBox.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.h

  Log Message:
  -----------
  [IFC][Ruby] text-emphasis is suppressed by annotation
https://bugs.webkit.org/show_bug.cgi?id=266482

Reviewed by Antti Koivisto.

This patch ensures that inline boxes are not stretched by text-emphasis when annotation is present.

1. Move text-emphasis logic over to InlineFormattingUtils.
2. Add checks for annotation before/after when text-emphasis content is inside ruby base.

* Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp:
(WebCore::Layout::InlineFormattingUtils::textEmphasisForInlineBox):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.h:
* Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h:
* Source/WebCore/layout/formattingContexts/inline/InlineLevelBoxInlines.h:
(WebCore::Layout::InlineLevelBox::setTextEmphasis):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBox.cpp:
(WebCore::Layout::LineBox::LineBox):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
(WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.h:
(WebCore::Layout::LineBoxBuilder::rootBox const):

Canonical link: https://commits.webkit.org/272119@main