[webkit-changes] [WebKit/WebKit] 1da279: [IFC][Ruby] Return correct accessibility roles

Antti Koivisto noreply at github.com
Fri Dec 15 05:53:53 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1da27950f8f1ec9d6cc023e460a1186a08b4e991
      https://github.com/WebKit/WebKit/commit/1da27950f8f1ec9d6cc023e460a1186a08b4e991
  Author: Antti Koivisto <antti at apple.com>
  Date:   2023-12-15 (Fri, 15 Dec 2023)

  Changed paths:
    M LayoutTests/accessibility/mac/ruby-hierarchy-roles-expected.txt
    M LayoutTests/accessibility/mac/ruby-hierarchy-roles.html
    M LayoutTests/platform/mac-wk1/TestExpectations
    M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
    M Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp

  Log Message:
  -----------
  [IFC][Ruby] Return correct accessibility roles
https://bugs.webkit.org/show_bug.cgi?id=266468
rdar://119712254

Reviewed by Alan Baradlay.

* LayoutTests/accessibility/mac/ruby-hierarchy-roles-expected.txt:
* LayoutTests/accessibility/mac/ruby-hierarchy-roles.html:

Update the test for the new ruby hierarchy.
Blockify by setting position:absolute.

* LayoutTests/platform/mac-wk1/TestExpectations:

Disable for now in WK1 because the setting leaks accross tests.

* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored const):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

Return the roles.

* Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp:
(WebCore::RenderTreeBuilder::Ruby::findOrCreateParentForStyleBasedRubyChild):

Return the existing anonymous ruby box for a ruby-block parent if there is one.

Canonical link: https://commits.webkit.org/272111@main




More information about the webkit-changes mailing list