[webkit-changes] [WebKit/WebKit] e5fd5e: [import-w3c-tests] Explicitly list all directories...

Sam Sneddon noreply at github.com
Fri Dec 15 04:42:40 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e5fd5e058c53623a1b6a13955bcaca9c006fd2cb
      https://github.com/WebKit/WebKit/commit/e5fd5e058c53623a1b6a13955bcaca9c006fd2cb
  Author: Sam Sneddon <gsnedders at apple.com>
  Date:   2023-12-15 (Fri, 15 Dec 2023)

  Changed paths:
    M LayoutTests/imported/w3c/resources/import-expectations.json
    M Tools/Scripts/webkitpy/style/checkers/jsonchecker.py
    M Tools/Scripts/webkitpy/style/checkers/jsonchecker_unittest.py
    M Tools/Scripts/webkitpy/w3c/test_downloader.py
    M Tools/Scripts/webkitpy/w3c/test_importer.py

  Log Message:
  -----------
  [import-w3c-tests] Explicitly list all directories we're not importing as skip
https://bugs.webkit.org/show_bug.cgi?id=214006

Reviewed by Jonathan Bedard.

Add a new value to import-expectations.json: "skip-new-directories".

"skip-new-directories" is mostly treated the same as "skip" (i.e.,
everything under it is skipped, unless marked as "import"). However,
unlike "skip", child files are imported, and child directories are added
to import-expectations.json as "skip" (thus the name).

We apply this to both "web-platform-tests" and "web-platform-tests/css",
to avoid importing new test suites for (presumably new) specifications.

By doing this, as opposed to applying "skip" directly to those
directories, we gain visibility to new test suites being added, as these
now cause a "skip" line to be added when doing a full import.

* LayoutTests/imported/w3c/resources/import-expectations.json:
* Tools/Scripts/webkitpy/style/checkers/jsonchecker.py:
(JSONImportExpectationsChecker.check):
* Tools/Scripts/webkitpy/w3c/test_downloader.py:
(TestDownloader.__init__):
(TestDownloader._init_paths_from_expectations):
(TestDownloader.update_import_expectations):
* Tools/Scripts/webkitpy/w3c/test_importer.py:
(TestImporter.__init__):
(TestImporter.do_import):
(TestImporter.should_skip_path):

Canonical link: https://commits.webkit.org/272109@main




More information about the webkit-changes mailing list