[webkit-changes] [WebKit/WebKit] 1f20be: Stop using CheckedPtrs with Geolocation
Chris Dumez
noreply at github.com
Thu Dec 14 14:49:24 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1f20be81cbe14a49cbe37658ed39fdb9bb384bc5
https://github.com/WebKit/WebKit/commit/1f20be81cbe14a49cbe37658ed39fdb9bb384bc5
Author: Chris Dumez <cdumez at apple.com>
Date: 2023-12-14 (Thu, 14 Dec 2023)
Changed paths:
M Source/WebCore/Modules/geolocation/Geolocation.h
M Source/WebKit/WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp
M Source/WebKit/WebProcess/Geolocation/GeolocationPermissionRequestManager.h
Log Message:
-----------
Stop using CheckedPtrs with Geolocation
https://bugs.webkit.org/show_bug.cgi?id=266422
Reviewed by Ryosuke Niwa.
Stop using CheckedPtrs with Geolocation. Geolocation is refcounted so we can
use RefPtr<Geolocation> for stack variables and we should be using WeakPtr
for storing as data members or in containers.
* Source/WebCore/Modules/geolocation/Geolocation.h:
* Source/WebKit/WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
(WebKit::GeolocationPermissionRequestManager::startRequestForGeolocation):
* Source/WebKit/WebProcess/Geolocation/GeolocationPermissionRequestManager.h:
Canonical link: https://commits.webkit.org/272073@main
More information about the webkit-changes
mailing list