[webkit-changes] [WebKit/WebKit] 3096c5: Samesite=Lax is not always working in Safari

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3096c561acce0ee5b181cd3d16339273d870ebcd
      https://github.com/WebKit/WebKit/commit/3096c561acce0ee5b181cd3d16339273d870ebcd
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-12-14 (Thu, 14 Dec 2023)

  Changed paths:
    M Source/WebKit/NetworkProcess/cache/NetworkCacheSubresourcesEntry.h

  Log Message:
  -----------
  Samesite=Lax is not always working in Safari
https://bugs.webkit.org/show_bug.cgi?id=265634
rdar://119362503

Reviewed by Brent Fulgham and Alex Christensen.

We were not setting isSameSite correctly when reading it from disk cache, which was then triggering different cookies being sent between
speculative loads and the actual would be loads.
Websites could use Vary Cookie headers to handle that case, but they do not tend to.

* Source/WebKit/NetworkProcess/cache/NetworkCacheSubresourcesEntry.h:
(WebKit::NetworkCache::SubresourceInfo::SubresourceInfo):

Canonical link: https://commits.webkit.org/272062@main