[webkit-changes] [WebKit/WebKit] 23026a: Stop using CheckedPtr / CheckedRef in TreeScopeOrd...

Chris Dumez noreply at github.com
Wed Dec 13 16:49:39 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 23026ae16e81f45dc1e4ecdac96c24eeb905e7a6
      https://github.com/WebKit/WebKit/commit/23026ae16e81f45dc1e4ecdac96c24eeb905e7a6
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-12-13 (Wed, 13 Dec 2023)

  Changed paths:
    M Source/WebCore/dom/TreeScope.cpp
    M Source/WebCore/dom/TreeScope.h
    M Source/WebCore/dom/TreeScopeOrderedMap.cpp
    M Source/WebCore/dom/TreeScopeOrderedMap.h

  Log Message:
  -----------
  Stop using CheckedPtr / CheckedRef in TreeScopeOrderedMap.h
https://bugs.webkit.org/show_bug.cgi?id=266370

Reviewed by Ryosuke Niwa.

Stop using CheckedPtr / CheckedRef in TreeScopeOrderedMap.h. Use WeakPtr / WeakRef
instead to generate more actionable crashes. This tested as performance neutral on
Speedometer 2 & 3.

* Source/WebCore/dom/TreeScope.cpp:
(WebCore::TreeScope::getAllElementsById const):
(WebCore::TreeScope::labelElementsForId):
* Source/WebCore/dom/TreeScope.h:
* Source/WebCore/dom/TreeScopeOrderedMap.cpp:
(WebCore::TreeScopeOrderedMap::add):
(WebCore::TreeScopeOrderedMap::remove):
(WebCore::TreeScopeOrderedMap::get const):
(WebCore::TreeScopeOrderedMap::getAll const):
(WebCore::TreeScopeOrderedMap::getElementsByLabelForAttribute const):
(WebCore::TreeScopeOrderedMap::getAllElementsById const):
* Source/WebCore/dom/TreeScopeOrderedMap.h:

Canonical link: https://commits.webkit.org/272015@main




More information about the webkit-changes mailing list