[webkit-changes] [WebKit/WebKit] 976e63: VTTScanner should copy the string it is parsing

Eric Carlson noreply at github.com
Wed Dec 13 14:27:43 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 976e6341b4a89ea4c8a4f27185d0219af1ac3189
      https://github.com/WebKit/WebKit/commit/976e6341b4a89ea4c8a4f27185d0219af1ac3189
  Author: Eric Carlson <eric.carlson at apple.com>
  Date:   2023-12-13 (Wed, 13 Dec 2023)

  Changed paths:
    M Source/WebCore/html/track/VTTScanner.cpp
    M Source/WebCore/html/track/VTTScanner.h

  Log Message:
  -----------
  VTTScanner should copy the string it is parsing
https://bugs.webkit.org/show_bug.cgi?id=266355
rdar://119621360

Reviewed by Chris Dumez.

Store the String to be parsed in a member variable instead of only storing pointers to the
start and end of the String to avoid crashes like the one caused by caused by 270868 at main.

* Source/WebCore/html/track/VTTScanner.cpp:
(WebCore::VTTScanner::VTTScanner):
* Source/WebCore/html/track/VTTScanner.h:

Canonical link: https://commits.webkit.org/272005@main




More information about the webkit-changes mailing list