[webkit-changes] [WebKit/WebKit] b4b989: [IFC][Ruby] Fix fast/ruby/bopomofo-rl.html

Alan Baradlay noreply at github.com
Wed Dec 13 06:48:46 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b4b989cedbce1e46b64ab0a6f7726aedacf9a9f0
      https://github.com/WebKit/WebKit/commit/b4b989cedbce1e46b64ab0a6f7726aedacf9a9f0
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-12-13 (Wed, 13 Dec 2023)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/InlineContentAligner.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineContentAligner.h
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/LineLayoutResult.h
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h

  Log Message:
  -----------
  [IFC][Ruby] Fix fast/ruby/bopomofo-rl.html
https://bugs.webkit.org/show_bug.cgi?id=266335

Reviewed by Antti Koivisto.

Annotation box alignment should follow ruby base alignment flow:
1. run justify alignment after line breaking (using Line::Runs)
2. offset justified runs (space-around) during display content building

* Source/WebCore/layout/formattingContexts/inline/InlineContentAligner.cpp:
(WebCore::Layout::InlineContentAligner::applyRubyAnnotationAlignmentOffset):
(WebCore::Layout::InlineContentAligner::applyRubyAlignOnAnnotationBox): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineContentAligner.h:
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::layoutInlineContent):
(WebCore::Layout::LineBuilder::placeInlineAndFloatContent):
* Source/WebCore/layout/formattingContexts/inline/LineLayoutResult.h:
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::processRubyContent):
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp:
(WebCore::Layout::RubyFormattingContext::applyRubyAlignOnAnnotationBox):
(WebCore::Layout::RubyFormattingContext::applyAnnotationAlignmentOffset):
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h:

Canonical link: https://commits.webkit.org/271980@main




More information about the webkit-changes mailing list