[webkit-changes] [WebKit/WebKit] 0eba4b: [svg] applying `rx` or `ry` through CSS exclusivel...
Antoine Quint
noreply at github.com
Tue Dec 12 23:10:30 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0eba4b6cab1736dee19afb4397af66a46b9cb01b
https://github.com/WebKit/WebKit/commit/0eba4b6cab1736dee19afb4397af66a46b9cb01b
Author: Antoine Quint <graouts at webkit.org>
Date: 2023-12-12 (Tue, 12 Dec 2023)
Changed paths:
A LayoutTests/imported/w3c/web-platform-tests/svg/shapes/rect-rx-set-by-css-expected.svg
A LayoutTests/imported/w3c/web-platform-tests/svg/shapes/rect-rx-set-by-css-ref.svg
A LayoutTests/imported/w3c/web-platform-tests/svg/shapes/rect-rx-set-by-css.svg
M Source/WebCore/rendering/svg/RenderSVGRect.cpp
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRect.cpp
Log Message:
-----------
[svg] applying `rx` or `ry` through CSS exclusively has no effect
https://bugs.webkit.org/show_bug.cgi?id=259646
rdar://113500023
Reviewed by Said Abou-Hallawa.
We should not be checking the XML attribute values for `rx` and `ry`
to determine whether a <rect> is rounded, but instead go through the
`SVGRenderStyle` which will the attribute values reflected as well as
account for the CSS properties.
* LayoutTests/imported/w3c/web-platform-tests/svg/shapes/rect-rx-set-by-css-expected.svg: Added.
* LayoutTests/imported/w3c/web-platform-tests/svg/shapes/rect-rx-set-by-css-ref.svg: Added.
* LayoutTests/imported/w3c/web-platform-tests/svg/shapes/rect-rx-set-by-css.svg: Added.
* Source/WebCore/rendering/svg/RenderSVGRect.cpp:
(WebCore::RenderSVGRect::updateShapeFromElement):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRect.cpp:
(WebCore::LegacyRenderSVGRect::updateShapeFromElement):
Canonical link: https://commits.webkit.org/271970@main
More information about the webkit-changes
mailing list