[webkit-changes] [WebKit/WebKit] 88a2e6: Fix crash caused by 270868 at main

Eric Carlson noreply at github.com
Tue Dec 12 20:40:34 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 88a2e6722dce9dcbe5d845a6b8f9655577306920
      https://github.com/WebKit/WebKit/commit/88a2e6722dce9dcbe5d845a6b8f9655577306920
  Author: Eric Carlson <eric.carlson at apple.com>
  Date:   2023-12-12 (Tue, 12 Dec 2023)

  Changed paths:
    M Source/WebCore/html/track/VTTRegion.cpp

  Log Message:
  -----------
  Fix crash caused by 270868 at main
https://bugs.webkit.org/show_bug.cgi?id=266310
rdar://119447227

Reviewed by Chris Dumez.

Store the region settions to be parsed in a local variable because VTTScanner only stores
pointers to the start and end of the String it is parsing, so passing it a temporary String
leaves it with pointers into an object that has been destroyed.

* Source/WebCore/html/track/VTTRegion.cpp:
(WebCore::VTTRegion::setRegionSettings):

Canonical link: https://commits.webkit.org/271965@main




More information about the webkit-changes mailing list