[webkit-changes] [WebKit/WebKit] 8db424: [WebGPU] Overrides with duplicate @id(values) are ...

mwyrzykowski noreply at github.com
Tue Dec 12 16:04:01 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8db4245f77a3baa881e5aeae9d80bd900e2af657
      https://github.com/WebKit/WebKit/commit/8db4245f77a3baa881e5aeae9d80bd900e2af657
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-12-12 (Tue, 12 Dec 2023)

  Changed paths:
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/shader_module/overrides-expected.txt
    M Source/WebGPU/WGSL/AttributeValidator.cpp
    M Source/WebGPU/WGSL/WGSLShaderModule.h

  Log Message:
  -----------
  [WebGPU] Overrides with duplicate @id(values) are not rejected
https://bugs.webkit.org/show_bug.cgi?id=266259
radar://119520604

Reviewed by Dan Glastonbury.

The integer value inside of @id(...) must be unique.

* LayoutTests/http/tests/webgpu/webgpu/api/validation/shader_module/overrides-expected.txt:
* Source/WebGPU/WGSL/AttributeValidator.cpp:
(WGSL::AttributeValidator::visit):
* Source/WebGPU/WGSL/WGSLShaderModule.h:
(WGSL::ShaderModule::containsOverride const):
(WGSL::ShaderModule::addOverride):

Canonical link: https://commits.webkit.org/271956@main




More information about the webkit-changes mailing list