[webkit-changes] [WebKit/WebKit] c1dcad: AX: Relationship origins may have no AX object cre...

AndresGonzalezApple noreply at github.com
Mon Dec 11 20:01:00 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c1dcaddd5b73856a077b2cc93901a0c3b77207e2
      https://github.com/WebKit/WebKit/commit/c1dcaddd5b73856a077b2cc93901a0c3b77207e2
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2023-12-11 (Mon, 11 Dec 2023)

  Changed paths:
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AXObjectCache.h

  Log Message:
  -----------
  AX: Relationship origins may have no AX object created for them.
https://bugs.webkit.org/show_bug.cgi?id=266247
<rdar://problem/119511840>

Reviewed by Tyler Wilcock.

In https://bugs.webkit.org/show_bug.cgi?id=265625 we addressed the issue of AX objects not being created for relation targets. This patch extends the fix for relation origins, which should also have an AX object. This problem became evident in WK1 where <input> elements may not have a renderer and therfore AXObjectCache::getOrCreate doesn't create an AX object for them.

* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::addRelation):
(WebCore::AXObjectCache::isDescendantOfRelatedNode):
(WebCore::AXObjectCache::isDescendantOfRelationTarget): Deleted.
* Source/WebCore/accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::getOrCreate):

Canonical link: https://commits.webkit.org/271909@main




More information about the webkit-changes mailing list