[webkit-changes] [WebKit/WebKit] 32bdd4: Port ContextMenuItemType to new IPC serialization ...

Claudio Saavedra noreply at github.com
Mon Dec 11 12:39:42 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 32bdd4a63f177448c04fc55e4298243efec5bbfa
      https://github.com/WebKit/WebKit/commit/32bdd4a63f177448c04fc55e4298243efec5bbfa
  Author: Claudio Saavedra <csaavedra at igalia.com>
  Date:   2023-12-11 (Mon, 11 Dec 2023)

  Changed paths:
    M Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp
    M Source/WebCore/inspector/InspectorFrontendHost.cpp
    M Source/WebCore/page/ContextMenuController.cpp
    M Source/WebCore/platform/ContextMenuItem.cpp
    M Source/WebCore/platform/ContextMenuItem.h
    M Source/WebKit/Shared/API/c/WKContextMenuItem.cpp
    M Source/WebKit/Shared/API/c/WKSharedAPICast.h
    M Source/WebKit/Shared/API/glib/WebKitContextMenuItem.cpp
    M Source/WebKit/Shared/WebContextMenuItem.cpp
    M Source/WebKit/Shared/WebContextMenuItemData.cpp
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
    M Source/WebKit/Shared/glib/WebContextMenuItemGlib.cpp
    M Source/WebKit/Shared/glib/WebContextMenuItemGlib.h
    M Source/WebKit/UIProcess/gtk/WebContextMenuProxyGtk.cpp
    M Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm
    M Source/WebKit/UIProcess/win/WebContextMenuProxyWin.cpp
    M Source/WebKit/UIProcess/win/WebView.cpp
    M Source/WebKitLegacy/mac/WebView/WebHTMLView.mm

  Log Message:
  -----------
  Port ContextMenuItemType to new IPC serialization format
https://bugs.webkit.org/show_bug.cgi?id=266079

Reviewed by Alex Christensen.

Port the ContextMenuItemType enum to the new IPC serialization
format to get rid of its EnumTraits. Take the chance to
also rename the enum members to remove the Type suffix, as it was
redundant.

* Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::showMediaControlsContextMenu):
* Source/WebCore/inspector/InspectorFrontendHost.cpp:
(WebCore::populateContextMenu):
* Source/WebCore/page/ContextMenuController.cpp:
(WebCore::separatorItem):
(WebCore::ContextMenuController::createAndAppendFontSubMenu):
(WebCore::ContextMenuController::createAndAppendSpellingAndGrammarSubMenu):
(WebCore::ContextMenuController::createAndAppendSpeechSubMenu):
(WebCore::ContextMenuController::createAndAppendUnicodeSubMenu):
(WebCore::ContextMenuController::createAndAppendWritingDirectionSubMenu):
(WebCore::ContextMenuController::createAndAppendTextDirectionSubMenu):
(WebCore::ContextMenuController::createAndAppendSubstitutionsSubMenu):
(WebCore::ContextMenuController::createAndAppendTransformationsSubMenu):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::addDebuggingItems):
(WebCore::ContextMenuController::checkOrEnableIfNeeded const):
* Source/WebCore/platform/ContextMenuItem.cpp:
(WebCore::ContextMenuItem::ContextMenuItem):
(WebCore::ContextMenuItem::setSubMenu):
* Source/WebCore/platform/ContextMenuItem.h:
* Source/WebKit/Shared/API/c/WKContextMenuItem.cpp:
(WKContextMenuItemCreateAsAction):
(WKContextMenuItemCreateAsCheckableAction):
(WKContextMenuItemGetType):
* Source/WebKit/Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
* Source/WebKit/Shared/API/glib/WebKitContextMenuItem.cpp:
(webkitContextMenuItemToWebContextMenuItemData):
(webkit_context_menu_item_new_from_stock_action):
(webkit_context_menu_item_new_from_stock_action_with_label):
(webkit_context_menu_item_new_with_submenu):
(webkit_context_menu_item_new_separator):
(webkit_context_menu_item_is_separator):
* Source/WebKit/Shared/WebContextMenuItem.cpp:
(WebKit::WebContextMenuItem::create):
(WebKit::WebContextMenuItem::separatorItem):
(WebKit::WebContextMenuItem::submenuItemsAsAPIArray const):
* Source/WebKit/Shared/WebContextMenuItemData.cpp:
(WebKit::WebContextMenuItemData::WebContextMenuItemData):
(WebKit::WebContextMenuItemData::core const):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/Shared/glib/WebContextMenuItemGlib.cpp:
(WebKit::WebContextMenuItemGlib::WebContextMenuItemGlib):
(WebKit::WebContextMenuItemGlib::createActionIfNeeded):
* Source/WebKit/Shared/glib/WebContextMenuItemGlib.h:
* Source/WebKit/UIProcess/gtk/WebContextMenuProxyGtk.cpp:
(WebKit::contextMenuItemActivatedCallback):
(WebKit::WebContextMenuProxyGtk::append):
(WebKit::WebContextMenuProxyGtk::buildMenu):
(WebKit::WebContextMenuProxyGtk::populateSubMenu):
(WebKit::WebContextMenuProxyGtk::populate):
* Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm:
(-[WKMenuTarget forwardContextMenuAction:]):
(WebKit::createMenuActionItem):
(WebKit::WebContextMenuProxyMac::getContextMenuItem):
* Source/WebKit/UIProcess/win/WebContextMenuProxyWin.cpp:
(WebKit::createMenuItem):
* Source/WebKit/UIProcess/win/WebView.cpp:
(WebKit::WebView::onMenuCommand):
* Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:
(createMenuItem):

Canonical link: https://commits.webkit.org/271896@main




More information about the webkit-changes mailing list