[webkit-changes] [WebKit/WebKit] 81d65a: [WebGPU] 'alias' not supported (https://www.w3.org...

Tadeu Zagallo noreply at github.com
Mon Dec 11 07:45:00 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 81d65a5b16f3bf2c1bc109176ea962425b41e8c6
      https://github.com/WebKit/WebKit/commit/81d65a5b16f3bf2c1bc109176ea962425b41e8c6
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-12-11 (Mon, 11 Dec 2023)

  Changed paths:
    M Source/WebGPU/WGSL/AST/AST.h
    M Source/WebGPU/WGSL/AST/ASTStringDumper.cpp
    M Source/WebGPU/WGSL/AST/ASTStringDumper.h
    A Source/WebGPU/WGSL/AST/ASTTypeAlias.h
    M Source/WebGPU/WGSL/AST/ASTVisitor.cpp
    M Source/WebGPU/WGSL/AST/ASTVisitor.h
    M Source/WebGPU/WGSL/Parser.cpp
    M Source/WebGPU/WGSL/ParserPrivate.h
    M Source/WebGPU/WGSL/TypeCheck.cpp
    M Source/WebGPU/WGSL/tests/valid/aliases.wgsl
    M Source/WebGPU/WebGPU.xcodeproj/project.pbxproj

  Log Message:
  -----------
  [WebGPU] 'alias' not supported (https://www.w3.org/TR/WGSL/#type-aliases) / error compiling shader opening https://playground.babylonjs.com/#N96NXC#106
https://bugs.webkit.org/show_bug.cgi?id=265341
rdar://118796398

Reviewed by Mike Wyrzykowski.

Add support for user-defined type aliases.

* Source/WebGPU/WGSL/AST/AST.h:
* Source/WebGPU/WGSL/AST/ASTStringDumper.cpp:
(WGSL::AST::StringDumper::visit):
* Source/WebGPU/WGSL/AST/ASTStringDumper.h:
* Source/WebGPU/WGSL/AST/ASTTypeAlias.h: Added.
* Source/WebGPU/WGSL/AST/ASTVisitor.cpp:
(WGSL::AST::Visitor::visit):
* Source/WebGPU/WGSL/AST/ASTVisitor.h:
* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::Parser<Lexer>::parseDeclaration):
(WGSL::Parser<Lexer>::parseTypeAlias):
* Source/WebGPU/WGSL/ParserPrivate.h:
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):
* Source/WebGPU/WGSL/tests/valid/aliases.wgsl:
* Source/WebGPU/WebGPU.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/271876@main




More information about the webkit-changes mailing list