[webkit-changes] [WebKit/WebKit] 4c4a4e: [GStreamer] HTTP source element leaks
Philippe Normand
noreply at github.com
Mon Dec 11 02:15:03 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4c4a4e062a4e44d58bde785226354f47a3197646
https://github.com/WebKit/WebKit/commit/4c4a4e062a4e44d58bde785226354f47a3197646
Author: Philippe Normand <philn at igalia.com>
Date: 2023-12-11 (Mon, 11 Dec 2023)
Changed paths:
M Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp
Log Message:
-----------
[GStreamer] HTTP source element leaks
https://bugs.webkit.org/show_bug.cgi?id=266177
Reviewed by Xabier Rodriguez-Calvar.
There was a reference cycle between the CachedResourceStreamingClient and WebKitWebSrc. Also,
sending a new ref of WebKitWebSrc to the main thread during basesrc::unlock was inducing an
additional leak.
* Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcMakeRequest):
(webKitWebSrcUnLock):
(CachedResourceStreamingClient::CachedResourceStreamingClient):
(CachedResourceStreamingClient::checkUpdateBlocksize):
(CachedResourceStreamingClient::responseReceived):
(CachedResourceStreamingClient::dataReceived):
(CachedResourceStreamingClient::accessControlCheckFailed):
(CachedResourceStreamingClient::loadFailed):
(CachedResourceStreamingClient::loadFinished):
Canonical link: https://commits.webkit.org/271864@main
More information about the webkit-changes
mailing list