[webkit-changes] [WebKit/WebKit] 394314: [ iOS ] fast/mediastream/video-srcObject-fit-fill....
youennf
noreply at github.com
Sun Dec 10 23:54:11 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3943142d2ef1777fc8977e6158eb10e053c3f8ca
https://github.com/WebKit/WebKit/commit/3943142d2ef1777fc8977e6158eb10e053c3f8ca
Author: Youenn Fablet <youennf at gmail.com>
Date: 2023-12-10 (Sun, 10 Dec 2023)
Changed paths:
M LayoutTests/fast/mediastream/video-srcObject-fit-fill.html
M LayoutTests/platform/ios/TestExpectations
M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm
M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm
M Source/WebKit/UIProcess/ios/WKVideoView.h
M Source/WebKit/UIProcess/ios/WKVideoView.mm
Log Message:
-----------
[ iOS ] fast/mediastream/video-srcObject-fit-fill.html is a constant text failure
https://bugs.webkit.org/show_bug.cgi?id=264293
rdar://118020922
Reviewed by Jer Noble.
The WebAVPlayerLayer was not receiving the gravity from WebProcess on iOS, which breaks its bounds computation.
Update RemoteLayerTreePropertyApplier::applyPropertiesToLayer to take into account WKVideoView.
We update fast/mediastream/video-srcObject-fit-fill.html to check for aspect ratio instead of pixel width to handle the various simulators.
* LayoutTests/fast/mediastream/video-srcObject-fit-fill.html:
* LayoutTests/platform/ios/TestExpectations:
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:
(WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer):
* Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm:
(WebKit::VideoPresentationManagerProxy::createViewWithID):
* Source/WebKit/UIProcess/ios/WKVideoView.h:
* Source/WebKit/UIProcess/ios/WKVideoView.mm:
(-[WKVideoView initWithFrame:playerView:]):
(+[WKVideoView playerLayerFromView:]):
Canonical link: https://commits.webkit.org/271859@main
More information about the webkit-changes
mailing list