[webkit-changes] [WebKit/WebKit] 9086d7: [IFC][Ruby] Force unicode-bidi to correct value

Antti Koivisto noreply at github.com
Sun Dec 10 09:08:55 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9086d78da701a2fe50818e7b730065c680dc95cf
      https://github.com/WebKit/WebKit/commit/9086d78da701a2fe50818e7b730065c680dc95cf
  Author: Antti Koivisto <antti at apple.com>
  Date:   2023-12-10 (Sun, 10 Dec 2023)

  Changed paths:
    M Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp
    M Source/WebCore/style/StyleAdjuster.cpp

  Log Message:
  -----------
  [IFC][Ruby] Force unicode-bidi to correct value
https://bugs.webkit.org/show_bug.cgi?id=266179
rdar://119462025

Reviewed by Alan Baradlay.

https://drafts.csswg.org/css-ruby-1/#bidi

"Bidi isolation is forced on all internal ruby boxes and the ruby container: the normal and embed
values of unicode-bidi compute to isolate, and bidi-override computes to isolate-override."

* Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp:
(WebCore::RenderTreeBuilder::Ruby::findOrCreateParentForStyleBasedRubyChild):

Set unicode-bidi::isolate for the anonymous base.

* Source/WebCore/style/StyleAdjuster.cpp:
(WebCore::Style::isRubyContainerOrInternalRubyBox):
(WebCore::Style::adjustUnicodeBidiForRuby):
(WebCore::Style::Adjuster::adjust const):

Adjust unicode-bidi for container and annotation boxes per spec.

Canonical link: https://commits.webkit.org/271839@main




More information about the webkit-changes mailing list