[webkit-changes] [WebKit/WebKit] 1dc773: Remove HAVE(OS_DARK_MODE_SUPPORT) inside PLATFORM(...

Anne van Kesteren noreply at github.com
Sat Dec 9 23:28:30 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1dc7738d93bb6d5326a0c2bd47e932eec216fc14
      https://github.com/WebKit/WebKit/commit/1dc7738d93bb6d5326a0c2bd47e932eec216fc14
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-12-09 (Sat, 09 Dec 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/mac/controls/WebControlView.mm
    M Source/WebCore/platform/mac/LocalDefaultSystemAppearance.h
    M Source/WebCore/platform/mac/LocalDefaultSystemAppearance.mm
    M Source/WebCore/rendering/RenderThemeMac.mm
    M Source/WebKit/UIProcess/mac/WebViewImpl.mm

  Log Message:
  -----------
  Remove HAVE(OS_DARK_MODE_SUPPORT) inside PLATFORM(MAC)
https://bugs.webkit.org/show_bug.cgi?id=266146

Reviewed by Tim Horton and Alex Christensen.

New functionality added in, e.g., RenderThemeMac, already did not use
this directive and it also makes things harder to read.

* Source/WebCore/platform/graphics/mac/controls/WebControlView.mm:
(-[WebControlTextFieldCell _adjustedCoreUIDrawOptionsForDrawingBordersOnly:]):
* Source/WebCore/platform/mac/LocalDefaultSystemAppearance.h:
(WebCore::LocalDefaultSystemAppearance::usingDarkAppearance const):
* Source/WebCore/platform/mac/LocalDefaultSystemAppearance.mm:
(WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance):
(WebCore::LocalDefaultSystemAppearance::~LocalDefaultSystemAppearance):
* Source/WebCore/rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor const):
(WebCore::RenderThemeMac::platformInactiveSelectionForegroundColor const):
(WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor const):
(WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor const):
(WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor const):
(WebCore::RenderThemeMac::systemColor const):
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::effectiveAppearanceIsDark):

Canonical link: https://commits.webkit.org/271830@main




More information about the webkit-changes mailing list