[webkit-changes] [WebKit/WebKit] f77181: AX: insertionPointLineNumber hits the main thread ...

Commit Queue noreply at github.com
Fri Dec 8 16:36:52 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f771811335e673c65f8ae5440811a0996a5bee45
      https://github.com/WebKit/WebKit/commit/f771811335e673c65f8ae5440811a0996a5bee45
  Author: Dominic Mazzoni <dmazzoni at google.com>
  Date:   2023-12-08 (Fri, 08 Dec 2023)

  Changed paths:
    A LayoutTests/accessibility/mac/insertion-point-line-number-expected.txt
    A LayoutTests/accessibility/mac/insertion-point-line-number.html
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h

  Log Message:
  -----------
  AX: insertionPointLineNumber hits the main thread even for single-line text fields
https://bugs.webkit.org/show_bug.cgi?id=265952
rdar://problem/119264904

Reviewed by Andres Gonzalez.

When a text field can only be single-line, either because it's an INPUT element or because
aria-multiline=false, we shouldn't hit the main thread for insertionPointLineNumber - just
return 0.

This can make navigating through web forms more responsive even when the main thread is
blocked.

* LayoutTests/accessibility/mac/insertion-point-line-number-expected.txt: Added.
* LayoutTests/accessibility/mac/insertion-point-line-number.html: Added.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeProperties):
(WebCore::AXIsolatedObject::canBeMultilineTextField):
(WebCore::AXIsolatedObject::insertionPointLineNumber const):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:

Canonical link: https://commits.webkit.org/271769@main




More information about the webkit-changes mailing list