[webkit-changes] [WebKit/WebKit] 967b21: Don't reuse a process in the cache when site isola...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 967b219ba093d62302d1a4c0708b275e8630403a
      https://github.com/WebKit/WebKit/commit/967b219ba093d62302d1a4c0708b275e8630403a
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-12-08 (Fri, 08 Dec 2023)

  Changed paths:
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebProcessPool.cpp

  Log Message:
  -----------
  Don't reuse a process in the cache when site isolation is enabled
https://bugs.webkit.org/show_bug.cgi?id=266092
rdar://119391925

Reviewed by Chris Dumez.

Otherwise we hit a release assertion in WebPageProxy::continueNavigationInNewProcess
when running with site isolation enabled.

There were two places where we were missing a shutdownPreventingScope between
getting the process and using it.  Additionally, sometimes we would get a process
that was already in the process cache from other iframes being removed or something.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadAlternateHTML):
(WebKit::WebPageProxy::continueNavigationInNewProcess):
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::processForNavigation):

Canonical link: https://commits.webkit.org/271760@main