[webkit-changes] [WebKit/WebKit] 415a49: Add an (off by default) code path to crash wheneve...

Brady Eidson noreply at github.com
Fri Dec 8 11:13:13 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 415a49b8e806d09b279c29b35bf028a3e32fd0dd
      https://github.com/WebKit/WebKit/commit/415a49b8e806d09b279c29b35bf028a3e32fd0dd
  Author: Brady Eidson <beidson at apple.com>
  Date:   2023-12-08 (Fri, 08 Dec 2023)

  Changed paths:
    M Source/WebKit/Shared/AuxiliaryProcess.cpp
    M Source/WebKit/Shared/AuxiliaryProcessCreationParameters.h
    M Source/WebKit/Shared/AuxiliaryProcessCreationParameters.serialization.in
    M Source/WebKit/Shared/Cocoa/CoreIPCSecureCoding.h
    M Source/WebKit/Shared/Cocoa/CoreIPCSecureCoding.mm
    M Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  -----------
  Add an (off by default) code path to crash whenever the CoreIPCSecureCoding wrapper is used
https://bugs.webkit.org/show_bug.cgi?id=266033
rdar://119344064

Reviewed by Alex Christensen.

This "crash on encountering an unspecified NSSecureCoding type" mode can be turned on via NSUserDefaults.

* Source/WebKit/Shared/AuxiliaryProcess.cpp:
(WebKit::AuxiliaryProcess::applyProcessCreationParameters):
* Source/WebKit/Shared/AuxiliaryProcessCreationParameters.h:
* Source/WebKit/Shared/AuxiliaryProcessCreationParameters.serialization.in:
* Source/WebKit/Shared/Cocoa/CoreIPCSecureCoding.h:
* Source/WebKit/Shared/Cocoa/CoreIPCSecureCoding.mm:
(WebKit::SecureCoding::internalShouldCrashOnSecureCoding):
(WebKit::SecureCoding::internalClassNamesExemptFromSecureCodingCrash):
(WebKit::SecureCoding::shouldCrashOnSecureCoding):
(WebKit::SecureCoding::classNamesExemptFromSecureCodingCrash):
(WebKit::SecureCoding::applyProcessCreationParameters):
(WebKit::crashWithClassName):
(WebKit::CoreIPCSecureCoding::CoreIPCSecureCoding):
* Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp:
(WebKit::AuxiliaryProcessProxy::auxiliaryProcessParameters):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/271746@main




More information about the webkit-changes mailing list