[webkit-changes] [WebKit/WebKit] 8555ad: WebCodecs HEVC isSupported returns true but decodi...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8555adfc8a29c5d85caff1f9d6c7f9c0dc8eb0b2
      https://github.com/WebKit/WebKit/commit/8555adfc8a29c5d85caff1f9d6c7f9c0dc8eb0b2
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-12-08 (Fri, 08 Dec 2023)

  Changed paths:
    A LayoutTests/http/wpt/webcodecs/hevc-decoder-annexb.https.any-expected.txt
    A LayoutTests/http/wpt/webcodecs/hevc-decoder-annexb.https.any.html
    A LayoutTests/http/wpt/webcodecs/hevc-decoder-annexb.https.any.js
    A LayoutTests/http/wpt/webcodecs/hevc-decoder-annexb.https.any.worker-expected.txt
    A LayoutTests/http/wpt/webcodecs/hevc-decoder-annexb.https.any.worker.html
    M LayoutTests/platform/glib/TestExpectations
    M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/nalu_rewriter.cc

  Log Message:
  -----------
  WebCodecs HEVC isSupported returns true but decoding failed
https://bugs.webkit.org/show_bug.cgi?id=262950
rdar://116768196

Reviewed by Jean-Yves Avenard.

Our nalu_rewriter logic was inaccurate and we were sometimes dropping data when translating annexb to hevc.
Fix the issue and add logging in error case.
Covered by added test.

* LayoutTests/http/wpt/webcodecs/hevc-decoder-annexb.https.any-expected.txt: Added.
* LayoutTests/http/wpt/webcodecs/hevc-decoder-annexb.https.any.html: Added.
* LayoutTests/http/wpt/webcodecs/hevc-decoder-annexb.https.any.js: Added.
(promise_test.t.const.promise.new.Promise):
(promise_test.t.const.decoder.new.VideoDecoder.output):
(promise_test.t.const.decoder.new.VideoDecoder.error):
* LayoutTests/http/wpt/webcodecs/hevc-decoder-annexb.https.any.worker-expected.txt: Added.
* LayoutTests/http/wpt/webcodecs/hevc-decoder-annexb.https.any.worker.html: Added.
* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/nalu_rewriter.cc:

Canonical link: https://commits.webkit.org/271728@main