[webkit-changes] [WebKit/WebKit] f75c48: Rewrite TestWebKitAPI.AutocorrectionTests.FontAtCa...

megangardner noreply at github.com
Fri Dec 8 04:30:50 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f75c4800598c8a9cdbcd31c970d0b381cc952370
      https://github.com/WebKit/WebKit/commit/f75c4800598c8a9cdbcd31c970d0b381cc952370
  Author: Megan Gardner <megan_gardner at apple.com>
  Date:   2023-12-08 (Fri, 08 Dec 2023)

  Changed paths:
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
    M Tools/TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm

  Log Message:
  -----------
  Rewrite TestWebKitAPI.AutocorrectionTests.FontAtCaretWhenUsingUICTFontTextStyle to not use fontForCaretSelection.
https://bugs.webkit.org/show_bug.cgi?id=266055
rdar://119344370

Reviewed by Tim Horton.

After https://commits.webkit.org/271515@main TestWebKitAPI.AutocorrectionTests.FontAtCaretWhenUsingUICTFontTextStyle
was failing because it used a method that no longer existed. The test needed to be re-written to use the API that
now gives the font information.

I also removed a duplicate line from the previous patch, no need to set the default black color twice.

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView textStylingAtPosition:inDirection:]):
* Tools/TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm:
(TEST):

Canonical link: https://commits.webkit.org/271724@main




More information about the webkit-changes mailing list