[webkit-changes] [WebKit/WebKit] 0ba44c: [JSC] Avoid checking if any function parameter is ...

Commit Queue noreply at github.com
Fri Dec 8 01:16:52 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0ba44cd43a98c967e1a629f0134447fa8ff88a34
      https://github.com/WebKit/WebKit/commit/0ba44cd43a98c967e1a629f0134447fa8ff88a34
  Author: Alexey Shvayka <ashvayka at apple.com>
  Date:   2023-12-08 (Fri, 08 Dec 2023)

  Changed paths:
    M Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp

  Log Message:
  -----------
  [JSC] Avoid checking if any function parameter is captured unless necessary
https://bugs.webkit.org/show_bug.cgi?id=266015
<rdar://problem/119337256>

Reviewed by Mark Lam.

With this change, `capturesAnyParameterByName` is computed only if it's actually used,
guarded by condition that includes `isSimpleParameterList`, which enables us to assert
isBindingNode().

Also, the loop is now terminated right after first captured parameter is found.

No new tests, no behavior change.

* Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):

Canonical link: https://commits.webkit.org/271719@main




More information about the webkit-changes mailing list