[webkit-changes] [WebKit/WebKit] 55786d: Generate serialization of WebImage
Alex Christensen
noreply at github.com
Thu Dec 7 20:30:17 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 55786dc300a3ef373750a36e6e34f50444ee0513
https://github.com/WebKit/WebKit/commit/55786dc300a3ef373750a36e6e34f50444ee0513
Author: Alex Christensen <achristensen at apple.com>
Date: 2023-12-07 (Thu, 07 Dec 2023)
Changed paths:
M Source/WebKit/CMakeLists.txt
M Source/WebKit/DerivedSources-input.xcfilelist
M Source/WebKit/DerivedSources.make
M Source/WebKit/Shared/API/c/cairo/WKImageCairo.cpp
M Source/WebKit/Shared/API/c/cg/WKImageCG.cpp
M Source/WebKit/Shared/UserData.cpp
M Source/WebKit/Shared/WebImage.cpp
M Source/WebKit/Shared/WebImage.h
A Source/WebKit/Shared/WebImage.serialization.in
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp
M Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp
M Source/WebKit/WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp
M Source/WebKit/WebProcess/WebPage/FindController.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
Log Message:
-----------
Generate serialization of WebImage
https://bugs.webkit.org/show_bug.cgi?id=266031
rdar://119343434
Reviewed by Chris Dumez.
It currently has a handwritten asymmetrical decoder that can decode nullptr
when a non-null WebImage was encoded. To correct this, I make WebImage able
to contain a null image buffer. I updated all the checks to reflect this.
* Source/WebKit/CMakeLists.txt:
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Shared/API/c/cg/WKImageCG.cpp:
(WKImageCreateFromCGImage):
* Source/WebKit/Shared/UserData.cpp:
(WebKit::UserData::encode):
(WebKit::UserData::decode):
* Source/WebKit/Shared/WebImage.cpp:
(WebKit::WebImage::createEmpty):
(WebKit::WebImage::create):
(WebKit::WebImage::WebImage):
(WebKit::WebImage::size const):
(WebKit::WebImage::parameters const):
(WebKit::WebImage::parametersAndHandle const):
(WebKit::WebImage::context const):
(WebKit::WebImage::copyNativeImage const):
(WebKit::WebImage::bitmap const):
(WebKit::WebImage::createCairoSurface):
(WebKit::WebImage::createHandle const):
* Source/WebKit/Shared/WebImage.h:
(WebKit::WebImage::isEmpty const):
* Source/WebKit/Shared/WebImage.serialization.in: Added.
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didGetImageForFindMatch):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::imageForRect):
* Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:
(WebKit::InjectedBundleRangeHandle::renderedImage):
* Source/WebKit/WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
(WebKit::InjectedBundleHitTestResult::image const):
* Source/WebKit/WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::getImageForFindMatch):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::snapshotAtSize):
(WebKit::WebPage::snapshotNode):
(WebKit::WebPage::drawRectToImage):
Canonical link: https://commits.webkit.org/271711@main
More information about the webkit-changes
mailing list