[webkit-changes] [WebKit/WebKit] dfc40f: [IFC][Ruby] Reserve horizontal space for inter-cha...

Alan Baradlay noreply at github.com
Thu Dec 7 09:49:40 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dfc40f631aac708c66fff9274f288d31256f0931
      https://github.com/WebKit/WebKit/commit/dfc40f631aac708c66fff9274f288d31256f0931
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-12-07 (Thu, 07 Dec 2023)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h

  Log Message:
  -----------
  [IFC][Ruby] Reserve horizontal space for inter-character annotation content
https://bugs.webkit.org/show_bug.cgi?id=265961

Reviewed by Antti Koivisto.

1. Move special, ruby base inline-box end handling to RubyFormattingContext.
2. Make space for inter-character annotation (right to the base content).

* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::candidateContentForLine):
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp:
(WebCore::Layout::baseLogicalWidthFromRubyBaseEnd):
(WebCore::Layout::RubyFormattingContext::annotationBoxLogicalWidth):
(WebCore::Layout::RubyFormattingContext::baseEndAdditionalLogicalWidth):
(WebCore::Layout::RubyFormattingContext::placeAnnotationBox):
(WebCore::Layout::RubyFormattingContext::baseLogicalWidthFromRubyBaseEnd): Deleted.
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h:

Canonical link: https://commits.webkit.org/271679@main




More information about the webkit-changes mailing list