[webkit-changes] [WebKit/WebKit] f0019c: [UnifiedPDF] PDFs load blank/white on iOS with Uni...

Abrar Rahman Protyasha noreply at github.com
Wed Dec 6 22:51:03 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f0019c9e8b3dfd16b8e112fd0253ddfeb7edb0a4
      https://github.com/WebKit/WebKit/commit/f0019c9e8b3dfd16b8e112fd0253ddfeb7edb0a4
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2023-12-06 (Wed, 06 Dec 2023)

  Changed paths:
    M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm

  Log Message:
  -----------
  [UnifiedPDF] PDFs load blank/white on iOS with UnifiedPDF enabled
https://bugs.webkit.org/show_bug.cgi?id=265966
rdar://118522690

Reviewed by Tim Horton.

The `PDFPluginEnabled` preference defaults to OFF for IOS_FAMILY
targets, so even when the `UnifiedPDFEnabled` preference is set, on iOS we
always report `shouldUsePDFPlugin==false`, which means a plugin is never
created and we never see a PDF load.

This patch fixes this bug by consulting whether or not the
`UnifiedPDFEnabled` has been set. If it has, then we should use the PDF
plugin.

* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::shouldUsePDFPlugin const):

Canonical link: https://commits.webkit.org/271660@main




More information about the webkit-changes mailing list