[webkit-changes] [WebKit/WebKit] 1e7aa8: [LBSE] Fix some masker issues

Rob Buis noreply at github.com
Wed Dec 6 13:23:20 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1e7aa8e2316ac92eb922cc9dbe5c283be9538979
      https://github.com/WebKit/WebKit/commit/1e7aa8e2316ac92eb922cc9dbe5c283be9538979
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2023-12-06 (Wed, 06 Dec 2023)

  Changed paths:
    M LayoutTests/svg/repaint/mask-object-bounding-box-expected.txt
    M LayoutTests/svg/repaint/mask-object-bounding-box-shrink-expected.txt
    M LayoutTests/svg/repaint/mask-object-bounding-box-shrink.html
    M LayoutTests/svg/repaint/mask-object-bounding-box-transformed-expected.txt
    M LayoutTests/svg/repaint/mask-object-bounding-box-transformed.html
    M LayoutTests/svg/repaint/mask-object-bounding-box.html
    M LayoutTests/svg/repaint/mask-user-space-on-use-expected.txt
    M LayoutTests/svg/repaint/mask-user-space-on-use-transformed-expected.txt
    M Source/WebCore/rendering/ReferencedSVGResources.cpp
    M Source/WebCore/rendering/ReferencedSVGResources.h
    M Source/WebCore/rendering/RenderElement.cpp

  Log Message:
  -----------
  [LBSE] Fix some masker issues
https://bugs.webkit.org/show_bug.cgi?id=265755

Reviewed by Nikolas Zimmermann.

Clients of masks were not properly added in ReferencedSVGResources::referencedSVGResourceIDs, add logic for that, now
repaint rect results for the mask-object-bounding-box* tests are more as expected than before.
Also the mask-object-bounding-box* tests used the wrong unit attribute, to be consistent with the equivalent
clip-path tests 'maskContentUnits' should be used. Finally, some more tests pass now, so update TestExpectations.

* LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations:
* LayoutTests/svg/repaint/mask-object-bounding-box-expected.txt:
* LayoutTests/svg/repaint/mask-object-bounding-box-shrink-expected.txt:
* LayoutTests/svg/repaint/mask-object-bounding-box-shrink.html:
* LayoutTests/svg/repaint/mask-object-bounding-box-transformed-expected.txt:
* LayoutTests/svg/repaint/mask-object-bounding-box-transformed.html:
* LayoutTests/svg/repaint/mask-object-bounding-box.html:
* LayoutTests/svg/repaint/mask-user-space-on-use-expected.txt:
* LayoutTests/svg/repaint/mask-user-space-on-use-transformed-expected.txt:
* Source/WebCore/rendering/ReferencedSVGResources.cpp:
(WebCore::ReferencedSVGResources::referencedSVGResourceIDs):
* Source/WebCore/rendering/ReferencedSVGResources.h:
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::updateReferencedSVGResources):

Canonical link: https://commits.webkit.org/271631@main




More information about the webkit-changes mailing list