[webkit-changes] [WebKit/WebKit] 3cd7a4: [WebGPU] GPUTexture.createView should report usefu...
mwyrzykowski
noreply at github.com
Wed Dec 6 12:38:33 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3cd7a4b56a4a060a1a7cfac76c43b38af5d6abf7
https://github.com/WebKit/WebKit/commit/3cd7a4b56a4a060a1a7cfac76c43b38af5d6abf7
Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
Date: 2023-12-06 (Wed, 06 Dec 2023)
Changed paths:
M LayoutTests/http/tests/webgpu/webgpu/api/validation/createView-expected.txt
M Source/WebGPU/WebGPU/Texture.h
M Source/WebGPU/WebGPU/Texture.mm
Log Message:
-----------
[WebGPU] GPUTexture.createView should report useful error messages when validation fails
https://bugs.webkit.org/show_bug.cgi?id=265930
<radar://119235084>
Reviewed by Tadeu Zagallo.
http/tests/webgpu/webgpu/api/validation/createView.html now passes locally
after not reporting validation errors on destroyed textures.
Also report some more useful error messages to enable better diagnosing of failures
when they occur.
* LayoutTests/http/tests/webgpu/webgpu/api/validation/createView-expected.txt:
* Source/WebGPU/WebGPU/Texture.h:
* Source/WebGPU/WebGPU/Texture.mm:
(WebGPU::Texture::errorValidatingTextureViewCreation const):
(WebGPU::Texture::createView):
(WebGPU::Texture::destroy):
(WebGPU::Texture::validateCreateView const): Deleted.
Canonical link: https://commits.webkit.org/271627@main
More information about the webkit-changes
mailing list