[webkit-changes] [WebKit/WebKit] 60d33b: Generate serialization of WebCore::Length

Alex Christensen noreply at github.com
Wed Dec 6 10:42:10 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 60d33b0e31c939b2fc947aeabde3137782d89f6c
      https://github.com/WebKit/WebKit/commit/60d33b0e31c939b2fc947aeabde3137782d89f6c
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-12-06 (Wed, 06 Dec 2023)

  Changed paths:
    M Source/WebCore/platform/Length.cpp
    M Source/WebCore/platform/Length.h
    M Source/WebKit/Shared/WebCoreArgumentCoders.cpp
    M Source/WebKit/Shared/WebCoreArgumentCoders.h
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  -----------
  Generate serialization of WebCore::Length
https://bugs.webkit.org/show_bug.cgi?id=265600
rdar://119000026

Reviewed by Brady Eidson.

Changing the data storage of WebCore::Length to a std::variant would increase sizeof(Length)
because of padding, but I achieved the same goal for serialization by making a variant accessor
and a constructor that takes a variant.

* Source/WebCore/platform/Length.cpp:
(WebCore::Length::typeFromIndex):
(WebCore::Length::Length):
(WebCore::Length::ipcData const):
(WebCore::Length::floatOrInt const):
* Source/WebCore/platform/Length.h:
* Source/WebKit/Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<Length>::encode): Deleted.
(IPC::ArgumentCoder<Length>::decode): Deleted.
* Source/WebKit/Shared/WebCoreArgumentCoders.h:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in.orig: Copied from Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in.

Canonical link: https://commits.webkit.org/271620@main




More information about the webkit-changes mailing list