[webkit-changes] [WebKit/WebKit] 942d83: Prepare <input type=checkbox switch> for multiple ...

Anne van Kesteren noreply at github.com
Wed Dec 6 07:26:26 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 942d831672a619657a92dd1fdce617603d6543b3
      https://github.com/WebKit/WebKit/commit/942d831672a619657a92dd1fdce617603d6543b3
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-12-06 (Wed, 06 Dec 2023)

  Changed paths:
    M Source/WebCore/html/CheckboxInputType.cpp
    M Source/WebCore/html/CheckboxInputType.h
    M Source/WebCore/html/HTMLInputElement.cpp
    M Source/WebCore/html/HTMLInputElement.h
    M Source/WebCore/rendering/RenderTheme.cpp
    M Source/WebCore/rendering/RenderTheme.h
    M Source/WebCore/rendering/RenderThemeMac.h

  Log Message:
  -----------
  Prepare <input type=checkbox switch> for multiple animation types
https://bugs.webkit.org/show_bug.cgi?id=265937

Reviewed by Aditya Keerthi.

On iOS the switch control will perform two separate types of
animations. Make it so that the infrastructure supports that in
principle.

Also prepare for supporting non-mouse events.

* Source/WebCore/html/CheckboxInputType.cpp:
(WebCore::CheckboxInputType::handleMouseDownEvent):
(WebCore::CheckboxInputType::handleMouseMoveEvent):
(WebCore::CheckboxInputType::willDispatchClick):
(WebCore::CheckboxInputType::startSwitchPointerTracking):
(WebCore::CheckboxInputType::disabledStateChanged):
(WebCore::CheckboxInputType::willUpdateCheckedness):
(WebCore::switchAnimationUpdateInterval):
(WebCore::switchAnimationDuration):
(WebCore::CheckboxInputType::switchAnimationStartTime const):
(WebCore::CheckboxInputType::setSwitchAnimationStartTime):
(WebCore::CheckboxInputType::isSwitchAnimating const):
(WebCore::CheckboxInputType::performSwitchAnimation):
(WebCore::CheckboxInputType::stopSwitchAnimation):
(WebCore::CheckboxInputType::switchAnimationProgress const):
(WebCore::CheckboxInputType::switchAnimationVisuallyOnProgress const):
(WebCore::CheckboxInputType::updateIsSwitchVisuallyOnFromAbsoluteLocation):
(WebCore::CheckboxInputType::switchAnimationTimerFired):
(WebCore::switchCheckedChangeAnimationUpdateInterval): Deleted.
(WebCore::CheckboxInputType::performSwitchCheckedChangeAnimation): Deleted.
(WebCore::CheckboxInputType::stopSwitchCheckedChangeAnimation): Deleted.
(WebCore::CheckboxInputType::switchCheckedChangeAnimationProgress const): Deleted.
(WebCore::CheckboxInputType::switchCheckedChangeAnimationTimerFired): Deleted.
* Source/WebCore/html/CheckboxInputType.h:
* Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::switchAnimationVisuallyOnProgress const):
(WebCore::HTMLInputElement::switchCheckedChangeAnimationProgress const): Deleted.
* Source/WebCore/html/HTMLInputElement.h:
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::updateSwitchThumbPartForRenderer):
(WebCore::updateSwitchTrackPartForRenderer):
* Source/WebCore/rendering/RenderTheme.h:
(WebCore::RenderTheme::switchAnimationVisuallyOnDuration const):
(WebCore::RenderTheme::switchCheckedChangeAnimationDuration const): Deleted.
* Source/WebCore/rendering/RenderThemeMac.h:

Canonical link: https://commits.webkit.org/271607@main




More information about the webkit-changes mailing list