[webkit-changes] [WebKit/WebKit] 7eae47: [webkit-patch] Remove land-cowhand, undeprecate re...

[Sam Sneddon]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7eae473bde06391fea03bcf11df6d400053502f2
      https://github.com/WebKit/WebKit/commit/7eae473bde06391fea03bcf11df6d400053502f2
  Author: Sam Sneddon <gsnedders at apple.com>
  Date:   2023-12-05 (Tue, 05 Dec 2023)

  Changed paths:
    M Tools/Scripts/webkitpy/common/system/outputtee.py
    M Tools/Scripts/webkitpy/test/main.py
    R Tools/Scripts/webkitpy/tool/bot/botinfo.py
    R Tools/Scripts/webkitpy/tool/bot/botinfo_unittest.py
    M Tools/Scripts/webkitpy/tool/bot/queueengine.py
    R Tools/Scripts/webkitpy/tool/bot/queueengine_unittest.py
    M Tools/Scripts/webkitpy/tool/commands/__init__.py
    M Tools/Scripts/webkitpy/tool/commands/abstractlocalservercommand.py
    M Tools/Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py
    M Tools/Scripts/webkitpy/tool/commands/commandtest.py
    M Tools/Scripts/webkitpy/tool/commands/download.py
    M Tools/Scripts/webkitpy/tool/commands/download_unittest.py
    M Tools/Scripts/webkitpy/tool/commands/format.py
    M Tools/Scripts/webkitpy/tool/commands/prettydiff.py
    M Tools/Scripts/webkitpy/tool/commands/queries.py
    R Tools/Scripts/webkitpy/tool/commands/queues.py
    R Tools/Scripts/webkitpy/tool/commands/queues_unittest.py
    R Tools/Scripts/webkitpy/tool/commands/queuestest.py
    M Tools/Scripts/webkitpy/tool/commands/rebaselineserver.py
    M Tools/Scripts/webkitpy/tool/commands/stepsequence.py
    M Tools/Scripts/webkitpy/tool/commands/suggestnominations.py
    M Tools/Scripts/webkitpy/tool/commands/upload.py
    M Tools/Scripts/webkitpy/tool/commands/upload_unittest.py
    M Tools/Scripts/webkitpy/tool/comments.py
    M Tools/Scripts/webkitpy/tool/main.py
    M Tools/Scripts/webkitpy/tool/mocktool.py
    M Tools/Scripts/webkitpy/tool/multicommandtool.py
    M Tools/Scripts/webkitpy/tool/multicommandtool_unittest.py
    R Tools/Scripts/webkitpy/tool/servers/gardeningserver.py
    R Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py
    M Tools/Scripts/webkitpy/tool/servers/reflectionhandler.py
    M Tools/Scripts/webkitpy/tool/steps/__init__.py
    M Tools/Scripts/webkitpy/tool/steps/addradar.py
    M Tools/Scripts/webkitpy/tool/steps/applywatchlist.py
    M Tools/Scripts/webkitpy/tool/steps/applywatchlist_unittest.py
    R Tools/Scripts/webkitpy/tool/steps/attachtobug.py
    R Tools/Scripts/webkitpy/tool/steps/checkpatchrelevance.py
    M Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py
    M Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py
    M Tools/Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py
    M Tools/Scripts/webkitpy/tool/steps/commit.py
    M Tools/Scripts/webkitpy/tool/steps/commit_unittest.py
    M Tools/Scripts/webkitpy/tool/steps/confirmdiff.py
    M Tools/Scripts/webkitpy/tool/steps/discardlocalchanges.py
    M Tools/Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py
    M Tools/Scripts/webkitpy/tool/steps/formatcppfiles.py
    R Tools/Scripts/webkitpy/tool/steps/haslanded.py
    R Tools/Scripts/webkitpy/tool/steps/haslanded_unittest.py
    R Tools/Scripts/webkitpy/tool/steps/metastep.py
    M Tools/Scripts/webkitpy/tool/steps/preparechangelog_unittest.py
    M Tools/Scripts/webkitpy/tool/steps/preparechangelogforrevert.py
    M Tools/Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py
    M Tools/Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py
    M Tools/Scripts/webkitpy/tool/steps/steps_unittest.py
    M Tools/Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py
    M Tools/Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py
    M Tools/Scripts/webkitpy/tool/steps/validatechangelogs.py
    M Tools/Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py

  Log Message:
  -----------
  [webkit-patch] Remove land-cowhand, undeprecate rebaseline-server
https://bugs.webkit.org/show_bug.cgi?id=221991

Reviewed by Jonathan Bedard.

This gets rid of the two last deprecated annotations, and then goes
through and deletes a lot of dead code in webkitpy.tool, as we haven't
previously done a proper cleanup from the prior removals.

* Tools/Scripts/webkitpy/common/system/outputtee.py:
(Tee.write):
(OutputTee): Deleted.
(OutputTee.__init__): Deleted.
(OutputTee.add_log): Deleted.
(OutputTee.remove_log): Deleted.
(OutputTee._open_log_file): Deleted.
(OutputTee._tee_outputs_to_files): Deleted.
* Tools/Scripts/webkitpy/test/main.py:
(main):
* Tools/Scripts/webkitpy/tool/bot/botinfo.py: Removed.
* Tools/Scripts/webkitpy/tool/bot/botinfo_unittest.py: Removed.
* Tools/Scripts/webkitpy/tool/bot/queueengine.py:
(QueueEngine):
(QueueEngine.exit_after_handled_error):
(TerminateQueue): Deleted.
(QueueEngineDelegate): Deleted.
(QueueEngineDelegate.queue_log_path): Deleted.
(QueueEngineDelegate.work_item_log_path): Deleted.
(QueueEngineDelegate.begin_work_queue): Deleted.
(QueueEngineDelegate.should_continue_work_queue): Deleted.
(QueueEngineDelegate.next_work_item): Deleted.
(QueueEngineDelegate.process_work_item): Deleted.
(QueueEngineDelegate.handle_unexpected_error): Deleted.
(QueueEngine.__init__): Deleted.
(QueueEngine.run): Deleted.
(QueueEngine._stopping): Deleted.
(QueueEngine._begin_logging): Deleted.
(QueueEngine._open_work_log): Deleted.
(QueueEngine._ensure_work_log_closed): Deleted.
(QueueEngine._now): Deleted.
(QueueEngine._sleep_message): Deleted.
(QueueEngine._sleep): Deleted.
* Tools/Scripts/webkitpy/tool/bot/queueengine_unittest.py: Removed.
* Tools/Scripts/webkitpy/tool/commands/__init__.py:
* Tools/Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
* Tools/Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
* Tools/Scripts/webkitpy/tool/commands/commandtest.py:
* Tools/Scripts/webkitpy/tool/commands/download.py:
(_prepare_state):
(ProcessBugsMixin._fetch_list_of_patches_to_process):
(LandCowhand): Deleted.
(LandCowhand._prepare_state): Deleted.
(ProcessURLsMixin): Deleted.
(ProcessURLsMixin._fetch_list_of_patches_to_process): Deleted.
* Tools/Scripts/webkitpy/tool/commands/download_unittest.py:
(test_land_cowhand): Deleted.
* Tools/Scripts/webkitpy/tool/commands/format.py:
* Tools/Scripts/webkitpy/tool/commands/prettydiff.py:
* Tools/Scripts/webkitpy/tool/commands/queries.py:
* Tools/Scripts/webkitpy/tool/commands/queues.py: Removed.
* Tools/Scripts/webkitpy/tool/commands/queues_unittest.py: Removed.
* Tools/Scripts/webkitpy/tool/commands/queuestest.py: Removed.
* Tools/Scripts/webkitpy/tool/commands/rebaselineserver.py:
(TestConfig.__init__):
* Tools/Scripts/webkitpy/tool/commands/stepsequence.py:
(StepSequenceErrorHandler): Deleted.
(StepSequenceErrorHandler.handle_script_error): Deleted.
(StepSequenceErrorHandler.handle_checkout_needs_update): Deleted.
* Tools/Scripts/webkitpy/tool/commands/suggestnominations.py:
* Tools/Scripts/webkitpy/tool/commands/upload.py:
* Tools/Scripts/webkitpy/tool/commands/upload_unittest.py:
* Tools/Scripts/webkitpy/tool/comments.py:
* Tools/Scripts/webkitpy/tool/main.py:
* Tools/Scripts/webkitpy/tool/mocktool.py:
* Tools/Scripts/webkitpy/tool/multicommandtool.py:
* Tools/Scripts/webkitpy/tool/multicommandtool_unittest.py:
* Tools/Scripts/webkitpy/tool/servers/gardeningserver.py: Removed.
* Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Removed.
* Tools/Scripts/webkitpy/tool/servers/reflectionhandler.py:
* Tools/Scripts/webkitpy/tool/steps/__init__.py:
* Tools/Scripts/webkitpy/tool/steps/addradar.py:
* Tools/Scripts/webkitpy/tool/steps/applywatchlist.py:
* Tools/Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
* Tools/Scripts/webkitpy/tool/steps/attachtobug.py: Removed.
* Tools/Scripts/webkitpy/tool/steps/checkpatchrelevance.py: Removed.
* Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
* Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
* Tools/Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
* Tools/Scripts/webkitpy/tool/steps/commit.py:
* Tools/Scripts/webkitpy/tool/steps/commit_unittest.py:
* Tools/Scripts/webkitpy/tool/steps/confirmdiff.py:
* Tools/Scripts/webkitpy/tool/steps/discardlocalchanges.py:
* Tools/Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py:
* Tools/Scripts/webkitpy/tool/steps/formatcppfiles.py:
* Tools/Scripts/webkitpy/tool/steps/haslanded.py: Removed.
* Tools/Scripts/webkitpy/tool/steps/haslanded_unittest.py: Removed.
* Tools/Scripts/webkitpy/tool/steps/metastep.py: Removed.
* Tools/Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
* Tools/Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
* Tools/Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
* Tools/Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py:
(SortXcodeProjectFiles.run):
* Tools/Scripts/webkitpy/tool/steps/steps_unittest.py:
* Tools/Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
* Tools/Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
* Tools/Scripts/webkitpy/tool/steps/validatechangelogs.py:
* Tools/Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:

Canonical link: https://commits.webkit.org/271597@main