[webkit-changes] [WebKit/WebKit] 849685: [WebAuthn] Implement getClientCapabilities()

Commit Queue noreply at github.com
Tue Dec 5 18:07:30 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 849685439d8df41be3632afc0c11e767f3b7e934
      https://github.com/WebKit/WebKit/commit/849685439d8df41be3632afc0c11e767f3b7e934
  Author: Garrett Davidson <garrett_davidson at apple.com>
  Date:   2023-12-05 (Tue, 05 Dec 2023)

  Changed paths:
    M Source/WebCore/CMakeLists.txt
    M Source/WebCore/DerivedSources-input.xcfilelist
    M Source/WebCore/DerivedSources-output.xcfilelist
    M Source/WebCore/DerivedSources.make
    M Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp
    M Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.h
    M Source/WebCore/Modules/webauthn/AuthenticatorCoordinatorClient.h
    M Source/WebCore/Modules/webauthn/PublicKeyCredential.cpp
    M Source/WebCore/Modules/webauthn/PublicKeyCredential.h
    M Source/WebCore/Modules/webauthn/PublicKeyCredential.idl
    A Source/WebCore/Modules/webauthn/PublicKeyCredentialClientCapabilities.cpp
    A Source/WebCore/Modules/webauthn/PublicKeyCredentialClientCapabilities.h
    A Source/WebCore/Modules/webauthn/PublicKeyCredentialClientCapabilities.idl
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebKit/Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h
    M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm
    M Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h
    M Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.messages.in
    M Source/WebKit/WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp
    M Source/WebKit/WebProcess/WebAuthentication/WebAuthenticatorCoordinator.h

  Log Message:
  -----------
  [WebAuthn] Implement getClientCapabilities()
https://bugs.webkit.org/show_bug.cgi?id=265710
rdar://119058559

Reviewed by Pascoe.

Implement PublicKeyCredentials.getClientCapabilities(). This function returns a Promise of
a String->bool maplike object which indicates support for various WebAuthn features. Most
of this patch is plumbing over to the UI process, which then calls into the platform to
get the list of features.

* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:
(WebCore::AuthenticatorCoordinator::getClientCapabilities const):
* Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.h:
* Source/WebCore/Modules/webauthn/AuthenticatorCoordinatorClient.h:
* Source/WebCore/Modules/webauthn/PublicKeyCredential.cpp:
(WebCore::PublicKeyCredential::getClientCapabilities):
* Source/WebCore/Modules/webauthn/PublicKeyCredential.h:
* Source/WebCore/Modules/webauthn/PublicKeyCredential.idl:
* Source/WebCore/Modules/webauthn/PublicKeyCredentialClientCapabilities.cpp: Copied from Source/WebCore/Modules/webauthn/PublicKeyCredential.idl.
(WebCore::PublicKeyCredentialClientCapabilities::PublicKeyCredentialClientCapabilities):
(WebCore::PublicKeyCredentialClientCapabilities::initializeMapLike):
(WebCore::PublicKeyCredentialClientCapabilities::add):
* Source/WebCore/Modules/webauthn/PublicKeyCredentialClientCapabilities.h: Copied from Source/WebCore/Modules/webauthn/PublicKeyCredential.idl.
(WebCore::PublicKeyCredentialClientCapabilities::create):
(WebCore::PublicKeyCredentialClientCapabilities::map const):
* Source/WebCore/Modules/webauthn/PublicKeyCredentialClientCapabilities.idl: Copied from Source/WebCore/Modules/webauthn/PublicKeyCredential.idl.
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebKit/Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h:
* Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
* Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h:
* Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.messages.in:
* Source/WebKit/WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp:
(WebKit::WebAuthenticatorCoordinator::getClientCapabilities):
* Source/WebKit/WebProcess/WebAuthentication/WebAuthenticatorCoordinator.h:

Canonical link: https://commits.webkit.org/271584@main




More information about the webkit-changes mailing list